Conversation
- Update go.viam.com/rdk v0.61.0 → v0.117.0 - Update go.viam.com/api v0.1.387 → v0.1.527 - Update go.viam.com/utils v0.1.128 → v0.4.13 - Switch golangci-lint from go.mod dependency to go run @v1.62.2 (matches rdk pattern) - Fix pointcloud.ReadPCD call in thumbnail.go (new signature requires second arg) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
v1.62.2 was built with Go 1.23 and rejects Go 1.25.1 targets. v1.64.8 is built with Go 1.26.1 and handles it correctly. Also remove two deprecated config options: - run.skip-dirs-use-default (already covered by issues.exclude-use-default) - linters-settings.gofumpt.lang-version (moved to global run.go) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Closed
rdk v0.117.0 changed Config.Validate to return (requiredDeps, optionalDeps []string, err error). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Without this, go run uses the host Go version, which may be lower than the version in go.mod and causes golangci-lint to reject the target. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- slam.FromDependencies → slam.FromProvider - resp.SessionId / resp.MapUrl → getter methods (proto style) - res.GetFileId() → extract file_id from res.GetBinaryDataId() Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
actionlint requires checkout@v4 or newer. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
JohnN193
commented
Mar 20, 2026
| go mod tidy | ||
| export pkgs="`go list -f '{{.Dir}}' ./... | grep -v /proto/`" && echo "$$pkgs" | xargs go vet -vettool=$(TOOL_BIN)/combined | ||
| GOGC=50 $(TOOL_BIN)/golangci-lint run -v --fix --config=./etc/golangci.yaml | ||
| GOTOOLCHAIN=go$(GOVERSION) GOGC=50 go run github.com/golangci/golangci-lint/cmd/golangci-lint@v1.64.8 run -v --fix --config=./etc/golangci.yaml |
Collaborator
Author
There was a problem hiding this comment.
linter was upset so i just tried copying what was in rdk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mechanical dependency and tooling updates — no behavior changes.
go.viam.com/rdkv0.61.0 → v0.117.0,apiv0.1.387 → v0.1.527,utilsv0.1.128 → v0.4.13GOTOOLCHAIN=go$(GOVERSION)to lint target sogo runuses the Go version fromgo.modrun.skip-dirs-use-defaultandlinters-settings.gofumpt.lang-versionPart of a series: PR A → [PR B] → [PR C] → [PR D]