surface session failures in map view, add ring text, fix save-local-map#18
Open
JohnN193 wants to merge 3 commits intopr-c-state-cleanupfrom
Open
surface session failures in map view, add ring text, fix save-local-map#18JohnN193 wants to merge 3 commits intopr-c-state-cleanupfrom
JohnN193 wants to merge 3 commits intopr-c-state-cleanupfrom
Conversation
Closed
JohnN193
force-pushed
the
pr-c-state-cleanup
branch
from
328432a to
c2df93b
Compare
JohnN193
force-pushed
the
pr-c-state-cleanup
branch
2 times, most recently
from
71b5798 to
151372c
Compare
- set GOTOOLCHAIN=go$(GOVERSION) so golangci-lint is built with the Go version declared in go.mod, not whatever the CI host has installed - replace deprecated slam.FromDependencies with slam.FromProvider - replace deprecated res.GetFileId() with res.GetBinaryDataId() - apply linter auto-fixes: proto getter style, range-over-int loop Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
adds a 5×7 dot-matrix font renderer (pcdtext.go) and draws "WAITING FOR / SESSION TO START" centered inside the progress ring, making it unambiguous to the viewer that this is not a real map. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Add lastSessionErr atomic to track failed sessions; polling thread checks metadata every cycle and sets it on END_STATUS_FAIL - PointCloudMap returns a "SESSION FAILED" PCD when lastSessionErr is set, covering both pre-map and post-map failure cases - Add D and L glyphs to font5x7 for "FAILED" text rendering - Add SLAMMapURL helper on AppClient to deduplicate URL construction; fixes save-local-map missing page=slam (causing redirect to /fleet) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
JohnN193
force-pushed
the
pr-c-state-cleanup
branch
from
151372c to
6d5fc3d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Polish, failure surfacing, and bug fixes.
Map view text
Renders "WAITING FOR / SESSION TO START" inside the progress ring using a 5×7 dot-matrix font, so it's unambiguously not a real map.
Session failure surfacing
The polling thread checks
GetMappingSessionMetadataByIDevery cycle. OnEND_STATUS_FAILit stores the error and clears the active job.PointCloudMapthen returns a "SESSION FAILED" PCD regardless of whether a map had previously been received — covers both the pre-map and post-map failure cases.Bug fixes
save-local-mapwas missingpage=slamin the returned URL, causing a redirect to/fleet/location/.... Added aSLAMMapURLhelper onAppClientto deduplicate this URL construction across bothStopJobandUploadPackage.BinaryDataId(org/location/file_id) as thefile_idmetadata field. The frontend constructs the thumbnail URL as/files/{org}/{location}/{file_id}, so this doubled the path segments. Now extracts just the trailing segment.Linter fixes (applied here since they reference the new APIs and structs added in earlier PRs)
slam.FromDependencieswithslam.FromProviderres.GetFileId()withres.GetBinaryDataId()(then extract the file_id segment — see thumbnail fix above)Part of a series: [PR A] → [PR B] → [PR C] → PR D