Skip to content

RSDK-7359: remove deprecated robot_part_id from cloudMetadataResponse #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
allisonschiang wants to merge 2 commits into
base: main
Choose a base branch
from
Open

RSDK-7359: remove deprecated robot_part_id from cloudMetadataResponse #830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b5f0de
init
allisonschiang Mar 19, 2026
870c1c6
Merge branch 'main' into RSDK-7359
allisonschiang Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions gen/js/robot/v1/robot_pb.d.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

30 changes: 0 additions & 30 deletions gen/js/robot/v1/robot_pb.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions proto/viam/robot/v1/robot.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,12 +352,13 @@ message LogResponse {}
message GetCloudMetadataRequest {}

message GetCloudMetadataResponse {
// Deprecated: use machine_part_id field.
string robot_part_id = 1 [deprecated = true];
string primary_org_id = 2;
string location_id = 3;
string machine_id = 4;
string machine_part_id = 5;

Copy link
Member Author

@allisonschiang allisonschiang Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do I need to make an announcement about this in breaking changes? since it was deprecated 2 years ago I'd hope it doesn't affect anything but I haven't gone through the deprecation process before

Copy link
Member

@cheukt cheukt Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep you should - in case anyone is still relying on this field

Copy link
Member

@cheukt cheukt Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will approve after announcement made

Copy link
Member Author

@allisonschiang allisonschiang Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do I need to give people time(one week?) before merging this?

reserved 1;
reserved "robot_part_id";
}

message RestartModuleRequest {
Expand Down
Loading
Loading