RSDK-13626: Remove GetImage and RenderFrame from camera server#590
Merged
RSDK-13626: Remove GetImage and RenderFrame from camera server#590
Conversation
hexbabe
requested review from
njooma and
stuqdog
and removed request for
a team
Pre-emptive removal ahead of viamrobotics/api#758 which deletes these RPCs from camera.proto. Both were already returning UNIMPLEMENTED. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
hexbabe
force-pushed
the
RSDK-13626-remove-getimage-renderframe
branch
from
91f2ce2 to
9ab7051
Compare
Member
Author
stuqdog
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GetImageandRenderFramedeclarations fromcamera_server.hppcamera_server.cppPre-emptive cleanup ahead of viamrobotics/api#758 which deletes these RPCs from
camera.proto. Both methods were already returningUNIMPLEMENTED. Without this change, theoverridespecifiers will cause compilation failures when the base class no longer declares these methods after proto regeneration.Test plan
🤖 Generated with Claude Code