Skip to content

Add a linting check in CI pipeline#18

Merged
david-mears-2 merged 11 commits intomainfrom
lint-in-ci
Feb 11, 2026
Merged

Add a linting check in CI pipeline#18
david-mears-2 merged 11 commits intomainfrom
lint-in-ci

Conversation

@david-mears-2
Copy link
Copy Markdown
Contributor

@david-mears-2 david-mears-2 commented Jan 5, 2026

npm run lint shouts if things are malformed - results in the CI 'unit test' workflow returning as failed. This is observed for commit a533c93.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.11%. Comparing base (e42ef1d) to head (71e2d13).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #18   +/-   ##
=======================================
  Coverage   98.11%   98.11%           
=======================================
  Files          25       25           
  Lines         584      584           
  Branches      144      144           
=======================================
  Hits          573      573           
  Misses         10       10           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@david-mears-2 david-mears-2 marked this pull request as draft January 5, 2026 12:24
@david-mears-2 david-mears-2 marked this pull request as ready for review February 9, 2026 14:52
Copy link
Copy Markdown
Contributor

@EmmaLRussell EmmaLRussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. If you wanted to, could run Lint in a separate job or after the tests. I find it a bit annoying if my tests don't get run because of lint but YMMV, and it all has to pass in the end...

david-mears-2 and others added 7 commits February 11, 2026 11:25
Co-authored-by: david-mears-2 <60350599+david-mears-2@users.noreply.github.com>
Co-authored-by: david-mears-2 <60350599+david-mears-2@users.noreply.github.com>
Split lint check into separate GitHub Actions workflow
Comment thread .github/workflows/tests.yml Outdated
@david-mears-2 david-mears-2 merged commit c01416e into main Feb 11, 2026
5 checks passed
@david-mears-2 david-mears-2 deleted the lint-in-ci branch February 11, 2026 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants