Skip to content

feat: cancel auto-delete timer when log entry is selected #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antfu merged 2 commits into from
Apr 1, 2026
+20 −1
Merged

feat: cancel auto-delete timer when log entry is selected #275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e482ea2
feat: cancel auto-delete timer when log entry is selected
JianJroh Apr 1, 2026
176a754
chore: add auto-dismiss and auto-delete fields to log form in playground
JianJroh Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/core/playground/src/pages/devtools.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ const logStatus = ref<'idle' | 'loading'>('idle')
const logId = ref('')
const logDescription = ref('')
const logStacktrace = ref('')
const logAutoDismiss = ref<number>()
const logAutoDelete = ref<number>()

// Update form
const updateId = ref('')
Expand Down Expand Up @@ -56,6 +58,8 @@ async function addLog() {
id: logId.value || undefined,
description: logDescription.value || undefined,
stacktrace: logStacktrace.value || undefined,
autoDismiss: logAutoDismiss.value,
autoDelete: logAutoDelete.value,
})
}

Expand Down Expand Up @@ -231,6 +235,14 @@ function incrementCounter() {
<span op50 text-xs>Stacktrace</span>
<textarea v-model="logStacktrace" rows="3" border="~ base" rounded px2 py1 text-sm bg-transparent outline-none resize-y font-mono />
</label>
<label flex="~ col gap-1">
<span op50 text-xs>Auto Dismiss</span>
<input v-model="logAutoDismiss" type="number" border="~ base" rounded px2 py1 text-sm bg-transparent outline-none>
</label>
<label flex="~ col gap-1">
<span op50 text-xs>Auto Delete</span>
<input v-model="logAutoDelete" type="number" border="~ base" rounded px2 py1 text-sm bg-transparent outline-none>
</label>
</div>
<div flex items-center gap-3 mt2>
<label flex items-center gap-1 text-xs>
Expand Down
9 changes: 8 additions & 1 deletion packages/core/src/client/webcomponents/components/views-builtin/ViewBuiltinLogs.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import type { DevToolsLogEntry, DevToolsLogEntryFrom, DevToolsLogLevel } from '@vitejs/devtools-kit'
import type { DocksContext } from '@vitejs/devtools-kit/client'
import { useClipboard, useTimeAgo } from '@vueuse/core'
import { computed, onMounted, ref } from 'vue'
import { computed, onMounted, ref, watch } from 'vue'
import { markLogsAsRead, useLogs } from '../../state/logs'
import FilterToggles from '../display/FilterToggles.vue'
import HashBadge from '../display/HashBadge.vue'
Expand Down Expand Up @@ -161,6 +161,13 @@ const selectedEntry = computed(() => {
return logsState.entries.find(e => e.id === selectedId.value) ?? null
})

watch(selectedEntry, async (entry) => {
if (!entry?.autoDelete)
return

await props.context.rpc.call('devtoolskit:internal:logs:update', entry.id, { autoDelete: 0 })
})

const selectedTimeAgo = useTimeAgo(computed(() => selectedEntry.value?.timestamp ?? Date.now()))
const { copy: copyStacktrace, copied: stacktraceCopied } = useClipboard()

Expand Down
Loading