Skip to content

Add support for TerraTorch Geospatial models served via the vLLM /pooling endpoint#610

Merged
sjmonson merged 15 commits intovllm-project:mainfrom
mgazz:geo
Mar 27, 2026
Merged

Add support for TerraTorch Geospatial models served via the vLLM /pooling endpoint#610
sjmonson merged 15 commits intovllm-project:mainfrom
mgazz:geo

Conversation

@mgazz
Copy link
Copy Markdown
Contributor

@mgazz mgazz commented Feb 25, 2026

Summary

This PR adds support for TerraTorch Geospatial models like Prithvi. Compared to traditional LLMs, Geospatial Models support image-to-image or tensor-to-tensor input/output, but they do not process text. Moreover they are served in vLLM at the /pooling endpoint.

Details

  • Support for the /pooling endpoint
  • A custom PoolingColumnMapper to map the prompt entry in datasets without creating conflict with the existing GenerativeColumnMapper
  • A new request handler for the pooling endpoint: PoolingRequestHandler

Test Plan

Related Issues


  • "I certify that all code in this PR is my own, except as noted below."

Use of AI

  • Includes AI-assisted code completion
  • Includes code generated by an AI application
  • Includes AI-generated tests (NOTE: AI written tests should have a docstring that includes ## WRITTEN BY AI ##)

@dbutenhof dbutenhof changed the title Add support for TerraTorch Geospatial models served via the vLLM /poling endpoint Add support for TerraTorch Geospatial models served via the vLLM /pooling endpoint Feb 27, 2026
@mgazz mgazz marked this pull request as ready for review March 11, 2026 10:02
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Mar 13, 2026

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @mgazz.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mgazz
Copy link
Copy Markdown
Contributor Author

mgazz commented Mar 18, 2026

Please wait before merging. After the rebase we can benchmark the Prithvi model but Terramind returns a server error. I am currently investigating the reason behind it.

@mgazz
Copy link
Copy Markdown
Contributor Author

mgazz commented Mar 20, 2026

@sjmonson we verified the problem was not a guidellm issue. The TerraMind deployment needed a bigger shared memory size.

@dbutenhof dbutenhof added this to the v0.6.0 milestone Mar 20, 2026
dbutenhof
dbutenhof previously approved these changes Mar 20, 2026
Copy link
Copy Markdown
Collaborator

@dbutenhof dbutenhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fairly straightforward (even if the entire concept of geospatial inference is more than slightly mysterious to me).

I made a minor comment on your documentation, which might help readers to follow the sequence... but I think that's a minor issue and I'm approving anyway. (Not that it really matters as you need a rebase now.)

FYI, the unit test failure is a known issue, and will be resolved when you rebase.

Comment thread docs/guides/geospatial.md Outdated
@sjmonson
Copy link
Copy Markdown
Collaborator

@Mergifyio rebase

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Mar 25, 2026

rebase

✅ Branch has been successfully rebased

jaredoconnell
jaredoconnell previously approved these changes Mar 25, 2026
Copy link
Copy Markdown
Collaborator

@jaredoconnell jaredoconnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything blocking, but I do have a comment on a design decision. I'm not the most familiar with geospacial models, but I was able to confirm that it ran.

Comment thread src/guidellm/data/preprocessors/mappers.py
Copy link
Copy Markdown
Collaborator

@sjmonson sjmonson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small nits,

Comment thread src/guidellm/backends/openai/http.py Outdated
Comment thread src/guidellm/data/preprocessors/mappers.py
@mgazz mgazz dismissed stale reviews from jaredoconnell and dbutenhof via 56efec6 March 26, 2026 16:23
Copy link
Copy Markdown
Collaborator

@dbutenhof dbutenhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation now gives --request-format values that won't work since you removed the "legacy" alias.

Comment thread docs/guides/geospatial.md Outdated
Comment thread docs/guides/geospatial.md Outdated
Comment thread docs/guides/geospatial.md Outdated
@mgazz
Copy link
Copy Markdown
Contributor Author

mgazz commented Mar 26, 2026

Sorry for the delay and thank you for the feedback. I will update the documentation to make it coherent. I will also provide a command to build the flood_detection_dataset.jsonl. This way we remove potential errors in designing a sample dataset.

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Mar 26, 2026

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @mgazz.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Mar 27, 2026

@mgazz, this project requires a linear history on feature branches.
Your PR contains merge commits. Please rebase your branch against main
and remove them.

You can do this by running:
git pull --rebase upstream main

@mergify mergify Bot added the needs-rebase label Mar 27, 2026
@sjmonson
Copy link
Copy Markdown
Collaborator

@Mergifyio rebase

mgazz and others added 15 commits March 27, 2026 14:51
…ling endpoint

Signed-off-by: Michele Gazzetti <michele.gazzetti1@ibm.com>
Signed-off-by: Michele Gazzetti <michele.gazzetti1@ibm.com>
Signed-off-by: Michele Gazzetti <michele.gazzetti1@ibm.com>
Signed-off-by: Michele Gazzetti <michele.gazzetti1@ibm.com>
Signed-off-by: Michele Gazzetti <michele.gazzetti1@ibm.com>
Signed-off-by: Michele Gazzetti <michele.gazzetti1@ibm.com>
Signed-off-by: Michele Gazzetti <michele.gazzetti1@ibm.com>
Signed-off-by: Michele Gazzetti <michele.gazzetti1@ibm.com>
Signed-off-by: Michele Gazzetti <michele.gazzetti1@ibm.com>
Signed-off-by: Michele Gazzetti <michele.gazzetti1@ibm.com>
Co-authored-by: Samuel Monson <smonson@irbash.net>
Signed-off-by: mgazz <michele.gazzetti1@ibm.com>
Signed-off-by: Michele Gazzetti <michele.gazzetti1@ibm.com>
Signed-off-by: Michele Gazzetti <michele.gazzetti1@ibm.com>
Signed-off-by: Michele Gazzetti <michele.gazzetti1@ibm.com>
Signed-off-by: Michele Gazzetti <michele.gazzetti1@ibm.com>
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Mar 27, 2026

rebase

✅ Branch has been successfully rebased

@sjmonson sjmonson merged commit 7d86db6 into vllm-project:main Mar 27, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for Geospatial models (served via vLLM)

4 participants