Add support for TerraTorch Geospatial models served via the vLLM /pooling endpoint#610
Add support for TerraTorch Geospatial models served via the vLLM /pooling endpoint#610sjmonson merged 15 commits intovllm-project:mainfrom
Conversation
|
This pull request has merge conflicts that must be resolved before it can be |
|
Please wait before merging. After the rebase we can benchmark the Prithvi model but Terramind returns a server error. I am currently investigating the reason behind it. |
|
@sjmonson we verified the problem was not a guidellm issue. The TerraMind deployment needed a bigger shared memory size. |
dbutenhof
left a comment
There was a problem hiding this comment.
This looks fairly straightforward (even if the entire concept of geospatial inference is more than slightly mysterious to me).
I made a minor comment on your documentation, which might help readers to follow the sequence... but I think that's a minor issue and I'm approving anyway. (Not that it really matters as you need a rebase now.)
FYI, the unit test failure is a known issue, and will be resolved when you rebase.
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
jaredoconnell
left a comment
There was a problem hiding this comment.
I don't see anything blocking, but I do have a comment on a design decision. I'm not the most familiar with geospacial models, but I was able to confirm that it ran.
dbutenhof
left a comment
There was a problem hiding this comment.
The documentation now gives --request-format values that won't work since you removed the "legacy" alias.
|
Sorry for the delay and thank you for the feedback. I will update the documentation to make it coherent. I will also provide a command to build the |
|
This pull request has merge conflicts that must be resolved before it can be |
|
@mgazz, this project requires a linear history on feature branches. You can do this by running: |
|
@Mergifyio rebase |
…ling endpoint Signed-off-by: Michele Gazzetti <michele.gazzetti1@ibm.com>
Signed-off-by: Michele Gazzetti <michele.gazzetti1@ibm.com>
Signed-off-by: Michele Gazzetti <michele.gazzetti1@ibm.com>
Signed-off-by: Michele Gazzetti <michele.gazzetti1@ibm.com>
Signed-off-by: Michele Gazzetti <michele.gazzetti1@ibm.com>
Signed-off-by: Michele Gazzetti <michele.gazzetti1@ibm.com>
Signed-off-by: Michele Gazzetti <michele.gazzetti1@ibm.com>
Signed-off-by: Michele Gazzetti <michele.gazzetti1@ibm.com>
Co-authored-by: Samuel Monson <smonson@irbash.net> Signed-off-by: mgazz <michele.gazzetti1@ibm.com>
Signed-off-by: Michele Gazzetti <michele.gazzetti1@ibm.com>
Signed-off-by: Michele Gazzetti <michele.gazzetti1@ibm.com>
✅ Branch has been successfully rebased |
Summary
This PR adds support for TerraTorch Geospatial models like Prithvi. Compared to traditional LLMs, Geospatial Models support image-to-image or tensor-to-tensor input/output, but they do not process text. Moreover they are served in vLLM at the /pooling endpoint.
Details
promptentry in datasets without creating conflict with the existing GenerativeColumnMapperTest Plan
Related Issues
Use of AI
## WRITTEN BY AI ##)