[wip] fix: do not require all nics to have an ip#720
Draft
tenthirtyam wants to merge 1 commit into
Draft
Conversation
github-actions
Bot
added
documentation
tenthirtyam
force-pushed
the
fix/do-not-require-all-nics-to-have-an-ip
branch
from
82ef049 to
b507229
Compare
Add optional ip_wait_adapter_index on vsphere-iso and vsphere-clone for environments where multiple NICs may receive routable addresses. Signed-off-by: Ryan Johnson <ryan@tenthirtyam.org>
tenthirtyam
force-pushed
the
fix/do-not-require-all-nics-to-have-an-ip
branch
from
b507229 to
43029ac
Compare
tenthirtyam
changed the title
Collaborator
Author
|
Moving this back to draft and updating the milestone as the the changes are not yet working as expected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add optional
ip_wait_adapter_indexonvsphere-isoandvsphere-clonefor environments where multiple NICs may receive routable addresses.Type
fix: Bug Fixfeat: Feature or Enhancementdocs: Documentationrefactor: Refactoringchore: Build, Dependencies, Workflows, etc.other: Other (Please describe.)Breaking Changes?
Tests
Output:
Documentation
Issue References
Closes #133
Release Note
Additional Information