Remove calls to get thumbnail post.#138
Open
jenkoian wants to merge 1 commit intovoceconnect:masterfrom
Open
Conversation
When using this plugin with https://github.com/humanmade/network-media-library it doesn't work, it seems this is because it attempts to retrieve the post of the thumbnail (needlessly afaict) which won't work because the image exists on a different site in the network. Removing these calls seems to fix the issue and allows for a better mutli site experience. I'm not sure of any adverse affects of this, but let me know if you can see one.
Author
|
Alternatively we could define hooks at the start and end of these functions so integrators can switch/restore blog. |
Author
|
Here's an example of the hooks approach that I've just done for a similar issue on fieldmanager alleyinteractive/wordpress-fieldmanager#738 let me know if you'd prefer that route. |
This was referenced Jan 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using this plugin with
https://github.com/humanmade/network-media-library it doesn't work, it
seems this is because it attempts to retrieve the post of the thumbnail
(needlessly afaict) which won't work because the image exists on a
different site in the network.
Removing these calls seems to fix the issue and allows for a better
mutli site experience. I'm not sure of any adverse affects of this, but
let me know if you can see one.