New package: plptools-1.0.26#59447
Open
JunePrimavera wants to merge 1 commit intovoid-linux:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apologies for submitting a second PR (#59427) and sending out more notifications - Pushed a broken commit, caused the PR to close automatically and can not be re-opened; seems the only way to continue is to create a new PR. Unclear what exactly caused the issue, but most likely because my fork was using the master branch; I've added the suggested changes as per @Duncaen 's review of the PR and put it on a separate branch in my repository to prevent it from happening again.
Definitely learnt several things from proposing this package to bear in mind in future!
Testing the changes
New package
Local build testing
New package for plptools. I have tested for x86_64 glibc and for i686 glibc. I don't have access to ARM hardware to test on, so that has not been tested - I don't see why it wouldn't work, however. This also provides its own service for ncpd; which isn't provided for runit upstream.