Merged
Conversation
Add detection for bun.lockb and bun.lock files so bun users get the same dependency caching as npm/pnpm/yarn users. VP supports bun as a package manager since v0.1.15. Closes #41
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Bun lockfile support to the action’s dependency cache detection, aligning it with VP’s Bun package manager support.
Changes:
- Detect
bun.lockbandbun.lockand classify them as a newLockFileType.Bun. - Treat Bun as a cacheable lockfile type when resolving dependency cache directories.
- Add unit tests for Bun lockfile detection and a CI job to exercise Bun caching.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/utils.ts |
Adds Bun lockfile patterns, infers Bun type, and includes Bun in cache directory resolution. |
src/utils.test.ts |
Adds unit tests covering explicit and auto-detected Bun lockfiles and priority behavior. |
src/types.ts |
Extends LockFileType with a Bun variant. |
dist/index.mjs |
Updates built action artifact to include Bun lockfile and cache logic. |
.github/workflows/test.yml |
Adds test-cache-bun workflow job to validate Bun caching behavior in CI. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Use startsWith("bun.") instead of includes("bun") in
inferLockFileType to avoid false positives (e.g. ubuntu.lock)
- Add bun.lockb to CI test matrix alongside bun.lock
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bun.lockbandbun.locklock file detection for dependency cachingBunvariant toLockFileTypeenum and wire it through cache directory resolutiontest-cache-bunCI job to verify bun caching in GitHub ActionsVP supports bun as a package manager since v0.1.15 — this aligns the action with that support.
Closes #41
Test plan
vp run test— 92 tests)vp run check:fix)vp run build)test-cache-bunjob passes on PR