fix(check): do not treat lint warnings as errors in exit code#1268
fix(check): do not treat lint warnings as errors in exit code#1268
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
How to use the Graphite Merge QueueAdd the label auto-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
When oxlint reports only warnings (0 errors), override the raw exit code to SUCCESS instead of propagating oxlint's non-zero exit code. This fixes ecosystem-ci failures where type-aware lint rules (e.g. typescript-eslint/await-thenable) produce warnings that cause `vp check --fix` to exit with code 1.
… snap test Verify that a plain `vp check` also exits with code 0 when only warnings are present, matching the --fix behavior.
fengmk2
force-pushed
the
fix/check-lint-warnings-exit-code
branch
from
391f785 to
b24b527
Compare
cpojer
left a comment
cpojer
left a comment
There was a problem hiding this comment.
Should this maybe also be fixed upstream in Oxlint?
|
@cpojer This is a bug in |
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2 participants
When oxlint reports only warnings (0 errors), override the raw exit code
to SUCCESS instead of propagating oxlint's non-zero exit code. This
fixes ecosystem-ci failures where type-aware lint rules (e.g.
typescript-eslint/await-thenable) produce warnings that cause
vp check --fixto exit with code 1.