Skip to content

fix(lint): resolve tsgolint on Windows with bun package manager#1269

Merged
graphite-app[bot] merged 1 commit intomainfrom
tsgolint-missing-at-bun-windows
Apr 2, 2026
Merged

fix(lint): resolve tsgolint on Windows with bun package manager#1269
graphite-app[bot] merged 1 commit intomainfrom
tsgolint-missing-at-bun-windows

Conversation

@fengmk2
Copy link
Copy Markdown
Member

@fengmk2 fengmk2 commented Apr 2, 2026

Bun stores packages in .bun/ cache dirs with symlinks, so the
hardcoded node_modules/.bin paths don't contain tsgolint.exe.
Add a fallback that resolves the real path of vite-plus and looks
for tsgolint in the sibling .bin directory.

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 2, 2026

Deploy Preview for viteplus-preview canceled.

Name Link
🔨 Latest commit ae9c5b7
🔍 Latest deploy log https://app.netlify.com/projects/viteplus-preview/deploys/69ce2293c90ff80008d8159e

Copy link
Copy Markdown
Member Author

fengmk2 commented Apr 2, 2026


How to use the Graphite Merge Queue

Add the label auto-merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@fengmk2
Copy link
Copy Markdown
Member Author

fengmk2 commented Apr 2, 2026

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@fengmk2
Copy link
Copy Markdown
Member Author

fengmk2 commented Apr 2, 2026

verify on windows
image

@fengmk2 fengmk2 force-pushed the tsgolint-missing-at-bun-windows branch from a015d78 to 767e6b0 Compare April 2, 2026 07:52
@fengmk2 fengmk2 requested review from branchseer, camc314 and cpojer April 2, 2026 07:53
@fengmk2 fengmk2 self-assigned this Apr 2, 2026
@fengmk2 fengmk2 marked this pull request as ready for review April 2, 2026 07:53
Copy link
Copy Markdown
Member

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😬

@graphite-app
Copy link
Copy Markdown

graphite-app bot commented Apr 2, 2026

Merge activity

graphite-app bot pushed a commit that referenced this pull request Apr 2, 2026
Bun stores packages in .bun/ cache dirs with symlinks, so the
hardcoded node_modules/.bin paths don't contain tsgolint.exe.
Add a fallback that resolves the real path of vite-plus and looks
for tsgolint in the sibling .bin directory.
@graphite-app graphite-app bot force-pushed the tsgolint-missing-at-bun-windows branch from 767e6b0 to 148cb7e Compare April 2, 2026 07:59
Bun stores packages in .bun/ cache dirs with symlinks, so the
hardcoded node_modules/.bin paths don't contain tsgolint.exe.
Add a fallback that resolves the real path of vite-plus and looks
for tsgolint in the sibling .bin directory.
@graphite-app graphite-app bot force-pushed the tsgolint-missing-at-bun-windows branch from 148cb7e to ae9c5b7 Compare April 2, 2026 08:02
@graphite-app graphite-app bot merged commit ae9c5b7 into main Apr 2, 2026
33 checks passed
@graphite-app graphite-app bot deleted the tsgolint-missing-at-bun-windows branch April 2, 2026 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants