fix(cli): wrap zsh completion in eval for dash compatibility#1280
Merged
fengmk2 merged 3 commits intovoidzero-dev:mainfrom Apr 3, 2026
Merged
fix(cli): wrap zsh completion in eval for dash compatibility#1280fengmk2 merged 3 commits intovoidzero-dev:mainfrom
fengmk2 merged 3 commits intovoidzero-dev:mainfrom
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
Member
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
nekomoyi
approved these changes
Apr 3, 2026
Contributor
Author
|
Most welcome. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where Ubuntu desktop login fails because the generated
~/.vite-plus/envfile contains Zsh-specific array syntax that is incompatible with the POSIXdashshell used during login.Changes
evalblock incrates/vite_global_cli/src/commands/env/setup.rs.evalwrapper.Verification
dash(POSIX compliant).pnpm testwas blocked by upstreamfspycompilation issues, but the fix follows the standard shell-portability pattern used in similar projects (e.g., nvm).