feat(installer): add standalone Windows .exe installer (vp-setup.exe) by fengmk2 · Pull Request #1293 · voidzero-dev/vite-plus

fengmk2 · 2026-04-04T09:43:22Z

Add a standalone vp-setup.exe Windows installer binary that installs
the vp CLI without requiring PowerShell, complementing the existing
irm https://vite.plus/ps1 | iex script-based installer.

Create vite_setup shared library crate extracting installation logic
(platform detection, registry queries, integrity verification, tarball
extraction, symlink/junction management) from vite_global_cli
Create vite_installer binary crate producing vp-setup.exe with
interactive prompts, silent mode (-y), progress bars, and Windows PATH
modification via direct registry API (no PowerShell dependency)
Update vite_global_cli to use vite_setup instead of inline upgrade
modules, ensuring upgrade and installer share identical logic
Add CI build/upload steps for installer in release workflow, attached
as GitHub Release assets
Add RFC document at rfcs/windows-installer.md

netlify · 2026-04-04T09:43:27Z

✅ Deploy Preview for viteplus-preview canceled.

Name	Link
🔨 Latest commit	`6153ccb`
🔍 Latest deploy log	https://app.netlify.com/projects/viteplus-preview/deploys/69d12f36b586850008481180

fengmk2 · 2026-04-04T09:43:36Z

feat(installer): add standalone Windows .exe installer (vp-setup.exe) #1293 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add the label auto-merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

.github/actions/build-upstream/action.yml

.github/workflows/test-standalone-install.yml

Add a standalone `vp-setup.exe` Windows installer binary that installs the vp CLI without requiring PowerShell, complementing the existing `irm https://vite.plus/ps1 | iex` script-based installer. - Create `vite_setup` shared library crate extracting installation logic (platform detection, registry queries, integrity verification, tarball extraction, symlink/junction management) from `vite_global_cli` - Create `vite_installer` binary crate producing `vp-setup.exe` with interactive prompts, silent mode (-y), progress bars, and Windows PATH modification via direct registry API (no PowerShell dependency) - Update `vite_global_cli` to use `vite_setup` instead of inline upgrade modules, ensuring upgrade and installer share identical logic - Add CI build/upload steps for installer in release workflow, attached as GitHub Release assets - Add RFC document at rfcs/windows-installer.md

- Remove dirs_home() and dead fallback in resolve_install_dir(), use get_vp_home() directly - Resolve install dir once in run() and pass through to all functions - Extract read_current_version() into vite_setup as a public function, reuse in save_previous_version() and the installer - Merge Cli/Options structs into single Options struct in cli.rs - Extract replace_windows_exe() helper to eliminate copy-paste in setup_bin_shims() - Remove unused LPWSTR type alias from windows_path.rs - Remove excessive "Step N" comments - Fix mixed path separator in interactive menu display

- Add interactive "Customize installation" submenu (option 2) allowing users to change version, registry, Node.js manager, and PATH settings - Add env file creation via `vp env setup --env-only` when Node.js manager is skipped (ensures shell env files exist in all code paths) - Add build.rs with /DEPENDENTLOADFLAG:0x800 linker flag for DLL hijacking prevention at load time (complements runtime mitigation) - Add test-vp-setup-exe CI job to test-standalone-install.yml testing silent installation from cmd, pwsh, and bash on Windows

The junction crate was moved to vite_setup when extracting the shared installation logic. cargo-shear correctly flagged it as unused.

Replace the flat numbered list with a phased ASCII diagram grouped into Resolve, Download & Verify, Install, Activate, and Configure phases. Add a function-to-crate mapping table and document the failure recovery boundary (pre/post Activate phase). Annotate conditional steps (save_previous_version only on upgrade, modify PATH gated by --no-modify-path).

- Update status from "Draft" to "Implemented" - Fix Code Sharing table: all install functions are in vite_setup::install, not separate submodules - Fix Dependency Graph: remove junction (indirect via vite_setup), add actual deps (vite_path, owo-colors) - Fix Customization submenu to match code (numbered items, no install dir) - Replace winreg code sample with raw FFI description (matches implementation) - Replace windows_sys DLL sample with raw FFI (matches implementation) - Remove winreg from Binary Size Budget, add raw FFI note - Fix Alternatives #4: raw FFI, not winreg - Fix CI snippets: rename vite-init to vp-setup, update test workflow to match actual test-vp-setup-exe job - Mark Implementation Phases 1-3 as done, Phase 4 as future

…ccess The zero-dependency pattern made sense for vite_trampoline (copied 5-10 times as shim files) but not for a single downloadable installer where readability matters more. Switch from 225 lines of unsafe raw Win32 FFI to ~80 lines of safe Rust using the winreg crate (~50-100 KB after LTO). WM_SETTINGCHANGE broadcast still uses a single raw FFI call since winreg doesn't wrap SendMessageTimeoutW.

- Extract VP_BINARY_NAME constant to avoid duplicated cfg!(windows) binary name literals - Remove redundant exists() check in replace_windows_exe — just attempt the rename unconditionally (rename failure is already ignored) - Trim verbose WHAT-comments to concise single-line doc comments

fengmk2 · 2026-04-04T14:03:13Z

crates/vite_installer/build.rs

+fn main() {
+    // On Windows, set DEPENDENTLOADFLAG to only search system32 for DLLs at load time.
+    // This prevents DLL hijacking when the installer is downloaded to a folder
+    // containing malicious DLLs (e.g. Downloads). Matches rustup's approach.


https://github.com/rust-lang/rustup/blob/main/build.rs#L51

Fix all high/P1/P2 issues from both adversarial and standard reviews: 1. Node.js manager auto-detect: port the full auto-detect logic from install.ps1/install.sh instead of unconditionally enabling shims. Checks VP_NODE_MANAGER env, existing shims, CI/devcontainer, system node availability — and prompts interactively when system node exists (matching install.ps1 behavior). Silent mode (-y) skips the prompt and does not enable shims when system node is present. 2. Same-version repair: when the target version is already installed, skip download/extract/deps but still run all post-activation setup (shims, Node.js manager, PATH, env files). This allows rerunning the installer to repair a broken installation. 3. Rollback protection: include the previous version in protected_versions during cleanup, matching the vp upgrade implementation. Prevents cleanup from deleting the rollback target. 4. Post-activation best-effort: setup_bin_shims, refresh_shims, and modify_path are now wrapped in if-let-Err with warnings instead of propagating errors. After activation (current junction swap), the core install has succeeded — configuration failures should not cause exit code 1.

- Move same-version check before platform package HTTP request: use resolve_version_string (1 HTTP call) first, then skip resolve_platform_package (2nd HTTP call) when version matches. Saves 1 HTTP request for tag matches, both for exact version matches. - Fix else { if let → else if let (clippy collapsible_else_if) - Consolidate VP_NODE_MANAGER handling: both "yes" and "no" now checked in should_enable_node_manager instead of split across cli.rs and main.rs - Make create_env_files return Result and report via print_warn, consistent with other best-effort post-activation steps

Move all user prompts to the menu phase — do_install is now prompt-free. The auto_detect_node_manager() function is pure logic (no I/O) that resolves the Node.js manager default based on: VP_NODE_MANAGER env, existing shims, CI/devcontainer, system node presence. The result is stored in opts.no_node_manager before showing the interactive menu, so the user sees the resolved value ("enabled"/"disabled") and can toggle it in the customize submenu before installation begins. When system node is present and no other signal overrides, the default is "disabled" — the user can enable it via the customize menu. In silent mode (-y), this means shims are not created unless explicitly requested via VP_NODE_MANAGER=yes or auto-detected (CI, no system node).

…tive mode When system node is present: - Interactive mode: default to enabled (matching install.ps1's Y/n prompt where Enter = yes). User can disable via customize menu. - Silent mode (-y): default to disabled (don't silently take over). This matches install.ps1 behavior where most interactive users who press Enter get node management enabled by default.

Replace dynamic matrix.shell in shell: field with explicit shell values per step. The matrix.shell expression was not recognized by the GitHub Actions YAML parser when used in the shell: context. Use a single job that verifies installation from pwsh, cmd, and bash sequentially.

- Update interactive menu examples to show "enabled"/"disabled" instead of "auto-detect" (value is now pre-computed) - Add Node.js Manager Auto-Detection section with priority table documenting the full auto-detect logic matching install.ps1/install.sh - Restructure Installation Flow diagram: local version check before HTTP, split resolve_version into resolve_version_string + resolve_platform_package, same-version repair path skips to CONFIGURE, cleanup moved to ACTIVATE - Update Existing Installation Handling: same version now repairs instead of exiting early - Document best-effort post-activation behavior and failure recovery - Update function mapping table with split registry functions - Update Test Workflow snippet to match actual single-job structure - Update Phase 2 description (winreg, pre-computed node manager, repair)

This function follows the same pattern as refresh_shims (spawn vp with different args) and belongs in the shared library alongside it.

.github/workflows/test-standalone-install.yml

… builds Use setup-dev-drive with ReFS (matching ci.yml) to speed up cargo build. Windows Defender skips ReFS dev drives, which significantly reduces build times on GitHub Actions Windows runners.

.github/workflows/test-standalone-install.yml

…_manager

.github/workflows/test-standalone-install.yml

+
+      - name: Install via vp-setup.exe (silent)
+        shell: pwsh
+        run: ${{ format('{0}/target/release/vp-setup.exe', env.DEV_DRIVE) }}


fengmk2 · 2026-04-04T15:38:50Z

rfcs/windows-installer.md

+
+- **Binary name**: `vp-setup.exe`
+- **Uninstall**: Rely on `vp implode` — no `--uninstall` flag in the installer
+- **Minimum Windows version**: Windows 10 1809+ (same as Rust's MSVC target)


The version information is not clear enough; at minimum, you need to specify when the version was released.

fengmk2 · 2026-04-04T15:48:48Z

rfcs/windows-installer.md

+
+### Phase 2: Direct Download URL
+
+Host at `https://vite.plus/vp-setup.exe` with architecture auto-detection (default x64).


should use void worker to handle the architecture detect logic.

fengmk2 self-assigned this Apr 4, 2026

github-advanced-security bot found potential problems Apr 4, 2026

View reviewed changes

.github/actions/build-upstream/action.yml Show resolved Hide resolved

github-advanced-security bot found potential problems Apr 4, 2026

View reviewed changes

.github/workflows/test-standalone-install.yml Fixed Show fixed Hide fixed

fengmk2 added 7 commits April 4, 2026 20:52

style: apply formatting fixes from vp check --fix

256ccbe

fix(build): remove unused junction dependency from vite_global_cli

4ed6f0e

The junction crate was moved to vite_setup when extracting the shared installation logic. cargo-shear correctly flagged it as unused.

fix(rfc): remove garbled Unicode characters in ASCII diagram

4dc36b5

fengmk2 force-pushed the windows-installer branch from 1b3a6a3 to 4dc36b5 Compare April 4, 2026 12:59

fengmk2 added 3 commits April 4, 2026 21:03

fengmk2 commented Apr 4, 2026

View reviewed changes

fengmk2 added 8 commits April 4, 2026 22:15

refactor(setup): move create_env_files from vite_installer to vite_setup

e2374ce

This function follows the same pattern as refresh_shims (spawn vp with different args) and belongs in the shared library alongside it.

fix(build): remove unused tracing dependency from vite_installer

816d7f1

github-advanced-security bot found potential problems Apr 4, 2026

View reviewed changes

.github/workflows/test-standalone-install.yml Show resolved Hide resolved

fengmk2 force-pushed the windows-installer branch from 672909f to 816d7f1 Compare April 4, 2026 15:07

fix(ci): add clone step to test-vp-setup-exe for workspace resolution

2049f52

github-advanced-security bot found potential problems Apr 4, 2026

View reviewed changes

.github/workflows/test-standalone-install.yml Show resolved Hide resolved

fix(build): fix rustfmt blank line in upgrade_check.rs imports

d043af5

fengmk2 added 2 commits April 4, 2026 23:17

perf(ci): add Dev Drive setup to test-vp-setup-exe for faster Windows…

adf6380

… builds Use setup-dev-drive with ReFS (matching ci.yml) to speed up cargo build. Windows Defender skips ReFS dev drives, which significantly reduces build times on GitHub Actions Windows runners.

fix(installer): update documentation URL to viteplus.dev/guide/

02e31a8

github-advanced-security bot found potential problems Apr 4, 2026

View reviewed changes

.github/workflows/test-standalone-install.yml Fixed Show fixed Hide fixed

fengmk2 added 4 commits April 4, 2026 23:24

fix(installer): update outdated comment to reference auto_detect_node…

b40f867

…_manager

chore: remove unnecessary comment in cli.rs

1391673

feat(installer): auto-detect CI environment to skip interactive prompts

83188f8

chore: remove unnecessary -y flag from CI (auto-detected)

c5b912e

github-advanced-security bot found potential problems Apr 4, 2026

View reviewed changes

.github/workflows/test-standalone-install.yml

- name: Install via vp-setup.exe (silent)

shell: pwsh

run: ${{ format('{0}/target/release/vp-setup.exe', env.DEV_DRIVE) }}

fix(ci): add flate to typos allowlist (flate2 crate name)

6153ccb

fengmk2 commented Apr 4, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(installer): add standalone Windows .exe installer (vp-setup.exe)#1293

feat(installer): add standalone Windows .exe installer (vp-setup.exe)#1293
fengmk2 wants to merge 27 commits intomainfrom
windows-installer

fengmk2 commented Apr 4, 2026

Uh oh!

netlify bot commented Apr 4, 2026 •

edited

Loading

Uh oh!

fengmk2 commented Apr 4, 2026

Uh oh!

Uh oh!

Uh oh!

fengmk2 Apr 4, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fengmk2 Apr 4, 2026

Uh oh!

fengmk2 Apr 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants


		### Phase 2: Direct Download URL

		Host at `https://vite.plus/vp-setup.exe` with architecture auto-detection (default x64).

Conversation

fengmk2 commented Apr 4, 2026

Uh oh!

netlify bot commented Apr 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for viteplus-preview canceled.

Uh oh!

fengmk2 commented Apr 4, 2026

How to use the Graphite Merge Queue

Uh oh!

Uh oh!

Uh oh!

fengmk2 Apr 4, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fengmk2 Apr 4, 2026

Choose a reason for hiding this comment

Uh oh!

fengmk2 Apr 4, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

netlify bot commented Apr 4, 2026 •

edited

Loading