You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
manual validation harness for the new compatibility + rebuild logic (the repo still has the existing pytest-asyncio collection failure: AttributeError: 'Package' object has no attribute 'obj', so direct pytest collection is still blocked)
The initialize method uses an undefined variable config when calling ensure_embedding_collection_compatibility. This will cause a NameError and crash the server on startup.
if not self._embedding_compat_check_disabled():
await ensure_embedding_collection_compatibility(
self._vikingdb_manager,
- config,+ self._config,
config_path=os.environ.get("OPENVIKING_CONFIG_FILE"),
)
Suggestion importance[1-10]: 9
__
Why: The variable config is indeed undefined in the initialize method scope; using self._config prevents a NameError, which is a critical correctness issue.
High
General
Remove blocking sync FS call
The fallback path uses a synchronous viking_fs.agfs.ls("/local") call inside an async function, which blocks the event loop. Remove this fallback and require the async list_account_roots method, or wrap the sync call in a thread pool.
Why: The fallback uses a synchronous call inside an async function, which can block the event loop. Removing it aligns with the PR's addition of the async list_account_roots method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openviking-rebuild-vectorsto delete stale per-account vectors and reindex all scopes from AGFS contentCloses #1066.
Validation
ruff check openviking/service/core.py openviking/service/vector_rebuild.py openviking/storage/embedding_compat.py openviking/storage/viking_fs.py openviking_cli/rebuild_vectors.py openviking_cli/utils/config/embedding_config.py openviking_cli/exceptions.py tests/storage/test_embedding_compat.py tests/service/test_vector_rebuild.pypython -m compileall openviking/service/core.py openviking/service/vector_rebuild.py openviking/storage/embedding_compat.py openviking/storage/viking_fs.py openviking_cli/rebuild_vectors.py openviking_cli/utils/config/embedding_config.py tests/storage/test_embedding_compat.py tests/service/test_vector_rebuild.pypython -m openviking_cli.rebuild_vectors --helppytest-asynciocollection failure:AttributeError: 'Package' object has no attribute 'obj', so directpytestcollection is still blocked)