fix: VikingDB volcengine URI prefix loss and stale is_leaf filter#294
Merged
fix: VikingDB volcengine URI prefix loss and stale is_leaf filter#294
Conversation
|
|
kkkwjx07
approved these changes
Feb 25, 2026
kkkwjx07
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
修复 VikingDB volcengine 后端的两个 bug 以及 S3 后端的一个 bug:
viking://前缀丢失,导致 Access Deniedmemory_deduplicator.py中残留已废弃的is_leaf字段过滤(PR feat: break change, remove is_leaf scalar and use level instead #271 遗漏)Related Issue
Fixes #288
Type of Change
Changes Made
VikingVectorIndexBackend中添加_restore_uri_fields()静态方法,在读取记录时还原uri/parent_uri字段的viking://前缀。在get()、fetch_by_uri()、search()、filter()四个出口处调用,scroll()和_remove_descendants()经由filter()间接覆盖。幂等操作,对 local/http 后端无副作用。memory_deduplicator.py中{"field": "is_leaf", "op": "must", "conds": [True]}替换为{"field": "level", "op": "must", "conds": [2]},与 PR feat: break change, remove is_leaf scalar and use level instead #271 的 schema 变更对齐。CopyObject()和ListAllObjects()方法;重构s3fs.Rename()支持目录级别的移动,通过服务端 copy + delete 递归处理整个子目录树。Testing
Checklist
Screenshots (if applicable)
N/A
Additional Notes
_restore_uri_fields()是volcengine_collection._sanitize_uri_value()的逆操作:去除首尾/后加上viking://前缀。通过not val.startswith("viking://")保证对 local/http 后端幂等安全。