fix: support short-format URI paths in VikingURI and VikingFS#301
Closed
fengjunhui wants to merge 1 commit intovolcengine:mainfrom
Closed
fix: support short-format URI paths in VikingURI and VikingFS#301fengjunhui wants to merge 1 commit intovolcengine:mainfrom
fengjunhui wants to merge 1 commit intovolcengine:mainfrom
Conversation
…gine#259) Auto-normalize short-format URIs (e.g., '/resources', 'user/memories') to full 'viking://' format, so callers don't need to always use the verbose prefix. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
冯俊辉 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Author
|
Closing in favor of #281 which already addresses this issue with a more comprehensive fix. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #259
/resources,user/memories) to fullviking://format inVikingURI.__init__, leveraging the existingVikingURI.normalize()methodVikingFS._is_accessible()so access checks no longer reject valid short-format pathsChanges
openviking_cli/utils/uri.pynormalize()in__init__before parsingopenviking/storage/viking_fs.pyVikingURI.normalize()in_is_accessible()tests/test_uri_short_format.pyTest plan
VikingURI("/resources")→viking://resources(wasValueError)VikingURI("user/memories")→viking://user/memories(wasValueError)VikingURI("viking://resources")unchanged (no regression)ValueErrorclient.ls("/resources")works end-to-end (wasPermissionError)🤖 Generated with Claude Code