Skip to content

Conversation

@brancz
Copy link
Contributor

@brancz brancz commented Nov 26, 2025

Looks like I only solved a subset of the issue with #5436

The test I added failed before the fix.

Signed-off-by: Frederic Branczyk <fbranczyk@gmail.com>
@brancz
Copy link
Contributor Author

brancz commented Nov 26, 2025

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 26, 2025

CodSpeed Performance Report

Merging #5541 will improve performances by 17.18%

Comparing polarsignals:projection (3ad77de) with develop (da6873b)

Summary

⚡ 5 improvements
✅ 1473 untouched
⏩ 235 skipped1

Benchmarks breakdown

Benchmark BASE HEAD Change
slice_arrow_buffer[1024] 397.8 ns 339.4 ns +17.18%
slice_arrow_buffer[128] 397.8 ns 339.4 ns +17.18%
slice_arrow_buffer[16384] 397.8 ns 339.4 ns +17.18%
slice_arrow_buffer[2048] 397.8 ns 339.4 ns +17.18%
slice_arrow_buffer[65536] 397.8 ns 339.4 ns +17.18%

Footnotes

  1. 235 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

❌ Patch coverage is 98.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 85.43%. Comparing base (fe4c81b) to head (3ad77de).
⚠️ Report is 7 commits behind head on develop.

Files with missing lines Patch % Lines
vortex-datafusion/src/persistent/opener.rs 98.33% 1 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@asubiotto asubiotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asubiotto
Copy link
Contributor

cc @a10y @AdamGS in case you want to take a look

Signed-off-by: Frederic Branczyk <fbranczyk@gmail.com>
@robert3005 robert3005 enabled auto-merge (squash) November 26, 2025 15:46
@robert3005 robert3005 merged commit 16d179b into vortex-data:develop Nov 26, 2025
47 checks passed
@a10y
Copy link
Contributor

a10y commented Nov 26, 2025

@brancz I think there are still issues here, see this simple example: #5550

Hoping to fix all of these edge cases as part of #5406

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants