-
Notifications
You must be signed in to change notification settings - Fork 107
Fix: Schema projection order mismatch from table/file schema #5541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Frederic Branczyk <fbranczyk@gmail.com>
|
Coincidentally, this is now the same strategy as what the parquet opener does: Map file schema to logical schema: https://github.com/apache/datafusion/blob/769f36732a284cec3d549bfcda50cb67684fb5dc/datafusion/datasource-parquet/src/opener.rs#L242 |
CodSpeed Performance ReportMerging #5541 will improve performances by 17.18%Comparing Summary
Benchmarks breakdown
Footnotes
|
Codecov Report❌ Patch coverage is
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
asubiotto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Frederic Branczyk <fbranczyk@gmail.com>
Looks like I only solved a subset of the issue with #5436
The test I added failed before the fix.