Experiment: Better Benchmarks

.github/workflows/bench.yml

@@ -18,6 +18,11 @@ jobs:
     timeout-minutes: 120
     steps:
       - uses: actions/checkout@v6
+      - uses: ./.github/actions/setup-rust
+        with:
+          repo-token: ${{ secrets.GITHUB_TOKEN }}
+      - name: Build s3_cat binary
+        run: cargo build --bin s3_cat --package bench-vortex --release
       - name: Setup AWS CLI
         uses: aws-actions/configure-aws-credentials@v5
         with:
@@ -30,7 +35,7 @@ jobs:
 
           sudo apt-get update && sudo apt-get install -y jq
           bash scripts/commit-json.sh > new-commit.json
-          bash scripts/cat-s3.sh vortex-benchmark-results-database commits.json new-commit.json
+          target/release/s3_cat vortex-benchmark-results-database-test commits.json new-commit.json
 
   bench:
     timeout-minutes: 120
@@ -69,7 +74,7 @@ jobs:
           RUSTFLAGS: "-C target-cpu=native -C force-frame-pointers=yes"
         # The main difference between this and `bench-pr.yml` is that we add the `lance` feature.
         run: |
-          cargo build --bin ${{ matrix.benchmark.id }} --package bench-vortex --profile release_debug --features lance
+          cargo build --bin ${{ matrix.benchmark.id }} --bin s3_cat --package bench-vortex --profile release_debug --features lance
 
       - name: Setup Polar Signals
         uses: polarsignals/gh-actions-ps-profiling@v0.6.0
@@ -96,7 +101,7 @@ jobs:
       - name: Upload Benchmark Results
         shell: bash
         run: |
-          bash scripts/cat-s3.sh vortex-benchmark-results-database data.json.gz ${{ matrix.benchmark.id }}.json
+          target/release_debug/s3_cat vortex-benchmark-results-database-test data.json.gz ${{ matrix.benchmark.id }}.json
   sql:
     uses: ./.github/workflows/sql-benchmarks.yml
     secrets: inherit

.github/workflows/ci.yml

@@ -619,15 +619,23 @@ jobs:
       - uses: ./.github/actions/setup-rust
         with:
           repo-token: ${{ secrets.GITHUB_TOKEN }}
-          toolchain: nightly-2025-06-26
-          targets: "wasm32-wasip1"
-          components: "rust-src"
+          targets: "wasm32-wasip1,wasm32-unknown-unknown"
+
       - name: Setup Wasmer
         uses: wasmerio/setup-wasmer@v3.1
-        # there is a compiler bug in nightly (but not in nightly-2025-06-26)
-      - run: cargo +nightly-2025-06-26 -Zbuild-std=panic_abort,std build --target wasm32-wasip1
+      - name: Build WASI binary
+        run: cargo build --target wasm32-wasip1
+        working-directory: ./wasm-test
+      - name: Run WASI test
+        run: wasmer run ./target/wasm32-wasip1/debug/wasm-test.wasm
         working-directory: ./wasm-test
-      - run: wasmer run ./target/wasm32-wasip1/debug/wasm-test.wasm
+
+      # wasm-bindgen-test with headless browser
+      # wasm-pack automatically installs matching wasm-bindgen-cli from Cargo.lock
+      - name: Install wasm-pack
+        run: curl https://rustwasm.github.io/wasm-pack/installer/init.sh -sSf | sh
+      - name: Run wasm-bindgen tests (headless Firefox)
+        run: wasm-pack test --headless --firefox
         working-directory: ./wasm-test
 
   miri:

.github/workflows/sql-benchmarks.yml

@@ -145,7 +145,7 @@ jobs:
         env:
           RUSTFLAGS: "-C target-cpu=native -C force-frame-pointers=yes"
         run: |
-          cargo build --bin query_bench --package bench-vortex --profile release_debug ${{ matrix.build_args }}
+          cargo build --bin query_bench --bin s3_cat --package bench-vortex --profile release_debug ${{ matrix.build_args }}
 
       - name: Generate data
         shell: bash
@@ -265,4 +265,4 @@ jobs:
         if: inputs.mode == 'develop'
         shell: bash
         run: |
-          bash scripts/cat-s3.sh vortex-benchmark-results-database data.json.gz results.json
+          target/release_debug/s3_cat vortex-benchmark-results-database-test data.json.gz results.json