Skip to content

Conversation

@connortsui20
Copy link
Contributor

@connortsui20 connortsui20 commented Dec 15, 2025

Fixes #5597

Since list views can be stored out of order and because there can be nulls at the end of the vector, we have to calculate the length of the child vector by looking at all views in the vector.

Note that this does not take validity into account, as I have no idea if DuckDB allows for complete garbage in their list views if they are null. At least in Arrow, that is not allowed.

Also adds 3 regression tests.

@codecov
Copy link

codecov bot commented Dec 15, 2025

Codecov Report

❌ Patch coverage is 97.19101% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.23%. Comparing base (c93b6a7) to head (896dc20).

Files with missing lines Patch % Lines
vortex-duckdb/src/convert/vector.rs 97.19% 5 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@connortsui20
Copy link
Contributor Author

decided to add specialization on the validity

@connortsui20 connortsui20 force-pushed the ct/fix-duckdb-list-import branch from 6fe3109 to 36af150 Compare December 16, 2025 19:10
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
@connortsui20 connortsui20 force-pushed the ct/fix-duckdb-list-import branch from 36af150 to 896dc20 Compare December 17, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants