Skip to content

Conversation

@connortsui20
Copy link
Contributor

@connortsui20 connortsui20 commented Dec 16, 2025

Fixes: #5633

I doubt that the extra enums I added for readability will hurt performance in any meaningful way.

@connortsui20
Copy link
Contributor Author

actually I just realized this does not handle EOF in the middle of a partial read as an error

@connortsui20 connortsui20 marked this pull request as draft December 16, 2025 18:30
@codecov
Copy link

codecov bot commented Dec 16, 2025

Codecov Report

❌ Patch coverage is 94.68085% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.03%. Comparing base (baafc71) to head (475e3aa).

Files with missing lines Patch % Lines
vortex-ipc/src/messages/reader_async.rs 88.09% 5 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

gatesn
gatesn previously approved these changes Dec 16, 2025
@connortsui20
Copy link
Contributor Author

@gatesn can you take a look again I made some changes

@connortsui20 connortsui20 marked this pull request as ready for review December 16, 2025 18:46
blaginin and others added 2 commits December 16, 2025 13:55
Signed-off-by: blaginin <dima@spiraldb.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
@codspeed-hq

This comment was marked as off-topic.

@connortsui20 connortsui20 enabled auto-merge (squash) December 17, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants