Map view types when converting arrow_expressions to vortex expressions #5765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I, Paul Timmins <paul@iqmo.com>, hereby add my Signed-off-by to this commit: 8ae0c04 Signed-off-by: Paul Timmins <paul@iqmo.com>
Codecov Report✅ All modified and coverable lines are covered by tests. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
danking
approved these changes
Dec 18, 2025
Contributor
danking
left a comment
danking
left a comment
There was a problem hiding this comment.
This is great and we should merge! Can you follow up with a test that writes and reads through DuckDB a Vortex file containing strings? I think paultiq included one at one point in one of his GitHub issues.
Author
|
@danking Do you want that test case in this PR or a separate? Happy to do either. |
Contributor
|
Separate is fine! Sorry I referred to you in the third person! GitHub mobile UI had me turned around haha |
I, Paul Timmins <paul@iqmo.com>, hereby add my Signed-off-by to this commit: de97c5b Signed-off-by: Paul Timmins <paul@iqmo.com>
This was referenced Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5759
This PR maps string_views to strings and binary_views to binary so that
to_substraitwill no longer raise ArrowNotImplementedError when constructing the substrait.Vortex supports expressions over views and Arrow compute doesn't, but to_substrait raises ArrowNotImplementedError based on Arrow compute kernels... regardless of the backend.