-
Notifications
You must be signed in to change notification settings - Fork 107
Feature: Make vortex-tui a library
#5779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
CodSpeed Performance ReportMerging #5779 will not alter performanceComparing Summary
Footnotes
|
Codecov Report✅ All modified and coverable lines are covered by tests. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
5fb2eac to
35330a5
Compare
| /// # Errors | ||
| /// | ||
| /// Raises any errors from subcommands. | ||
| pub async fn launch() -> anyhow::Result<()> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to take session as an argument here!
Closes: #5742
Also adds documentation everywhere and refactors a bunch of stuff to be more ergonomic since it's now "more" user facing.