update environment_manager, robot_manager and isaac_simulation.py#22
Open
KhaazixGod wants to merge 3 commits intovoshch:humblefrom
Open
update environment_manager, robot_manager and isaac_simulation.py#22KhaazixGod wants to merge 3 commits intovoshch:humblefrom
KhaazixGod wants to merge 3 commits intovoshch:humblefrom
Conversation
Author
voshch
requested changes
Feb 24, 2026
Owner
voshch
left a comment
voshch
left a comment
There was a problem hiding this comment.
This PR changes a bunch of files and functionality that it shouldn't.
- update the arena-isaac commit id to Arena-Rosnav/arena-isaac#8,
- restore all original logger levels,
- remove new debug messages or reduces them to
logger.debug, - restore the original robot manager functionality,
- place imports at the top of the file,
- remove unnecessary comments.
Author
|
@voshch i changed like you said can you review again for me? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can you please discard all .yaml file changes and behaviour tree changes.