-
Notifications
You must be signed in to change notification settings - Fork 5
Add comprehensive code quality tooling and formatting standards #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
ee218a1
build: add code-quality tooling (lint/format) for every language
claude f88e66a
style: apply lint auto-fixers across all ports
claude b00e0b5
style: resolve `make lint` findings across all ports
claude a6bbdaa
build: add dependency / SAST / supply-chain static analysis
claude 8b058f6
ci: add CodeQL workflow; close the Go jm/jt parity gap
claude 92031e2
refactor: use the canonical `jm`/`jt` builder names everywhere; drop …
claude f6a29f1
cs, zig: implement the jm / jt JSON builders
claude c8b4732
zig: complete the API surface; mark the port Complete
claude 421defd
docs: mark the C# port Complete; add Zig to REPORT.md
claude 38f0602
ci: fix the lint / CodeQL CI jobs (PR #69)
claude 312fbba
ci: pin the C# SDK roll-forward so lint-cs stays on .NET 8
claude 3035c84
test: replace all '>' (not just the first) in the pathify null-marker…
claude c676681
ci: use pwsh (not cmd) for the Kotlin Windows test step
claude 3e57a42
ci: remove the CodeQL advanced-config workflow
claude 5ca5795
ci: add an explicit read-only permissions block to the workflows
claude 7a2c173
ci: isolate composer install from setup-php's auth.json
claude aafd1d4
ci: opt JS actions into Node 24
claude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,167 @@ | ||
| name: Lint | ||
|
|
||
| on: | ||
| push: | ||
| branches: [ main, dev ] | ||
| pull_request: | ||
| branches: [ main, dev ] | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| env: | ||
| # actions/checkout and the setup-* actions still bundle the deprecated | ||
| # Node 20 runtime; opt them into Node 24 now (default from 2026-06-02). | ||
| FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true | ||
|
|
||
| jobs: | ||
| lint-ts: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 'lts/*' | ||
| - working-directory: ./ts | ||
| run: npm install | ||
| - working-directory: ./ts | ||
| run: make lint | ||
|
|
||
| lint-js: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 'lts/*' | ||
| - working-directory: ./js | ||
| run: npm install | ||
| - working-directory: ./js | ||
| run: make lint | ||
|
|
||
| lint-py: | ||
|
github-advanced-security[bot] marked this conversation as resolved.
Fixed
|
||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: '3.12' | ||
| - working-directory: ./py | ||
| run: pip install -r requirements-dev.txt | ||
| - working-directory: ./py | ||
| run: make lint | ||
|
|
||
| lint-go: | ||
|
github-advanced-security[bot] marked this conversation as resolved.
Fixed
|
||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-go@v5 | ||
| with: | ||
| go-version: '1.24' | ||
| - name: Install golangci-lint | ||
| run: curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/HEAD/install.sh | sh -s -- -b "$(go env GOPATH)/bin" v2.5.0 | ||
| - working-directory: ./go | ||
| run: | | ||
| gobin="$(go env GOPATH)/bin" | ||
| PATH="$gobin:$PATH" make lint | ||
|
|
||
| lint-rs: | ||
|
github-advanced-security[bot] marked this conversation as resolved.
Fixed
|
||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: dtolnay/rust-toolchain@stable | ||
| with: | ||
| components: clippy, rustfmt | ||
| - working-directory: ./rs | ||
| run: make lint | ||
|
|
||
| lint-rb: | ||
|
github-advanced-security[bot] marked this conversation as resolved.
Fixed
|
||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: ruby/setup-ruby@v1 | ||
| with: | ||
| ruby-version: '3.3' | ||
| bundler-cache: true | ||
| working-directory: ./rb | ||
| - working-directory: ./rb | ||
| run: make lint | ||
|
|
||
| lint-php: | ||
|
github-advanced-security[bot] marked this conversation as resolved.
Fixed
|
||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: shivammathur/setup-php@v2 | ||
| with: | ||
| php-version: '8.2' | ||
| - working-directory: ./php | ||
| # Use a fresh COMPOSER_HOME: setup-php intermittently writes a | ||
| # malformed github-oauth token to its auth.json, which makes | ||
| # `composer install` abort. We don't need authenticated installs here. | ||
| run: composer install | ||
| env: | ||
| COMPOSER_HOME: ${{ runner.temp }}/composer-home | ||
| - working-directory: ./php | ||
| run: make lint | ||
|
|
||
| lint-java: | ||
|
github-advanced-security[bot] marked this conversation as resolved.
Fixed
|
||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-java@v4 | ||
| with: | ||
| distribution: temurin | ||
| java-version: '17' | ||
| - working-directory: ./java | ||
| run: make lint | ||
|
|
||
| lint-kt: | ||
|
github-advanced-security[bot] marked this conversation as resolved.
Fixed
|
||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-java@v4 | ||
| with: | ||
| distribution: temurin | ||
| java-version: '17' | ||
| - working-directory: ./kt | ||
| run: ./gradlew detekt ktlintCheck | ||
|
|
||
| lint-lua: | ||
|
github-advanced-security[bot] marked this conversation as resolved.
Fixed
|
||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: leafo/gh-actions-lua@v10 | ||
| with: | ||
| luaVersion: "5.4" | ||
| - uses: leafo/gh-actions-luarocks@v4 | ||
| - run: luarocks install luacheck | ||
| - working-directory: ./lua | ||
| run: luacheck src test | ||
|
|
||
| lint-zig: | ||
|
github-advanced-security[bot] marked this conversation as resolved.
Fixed
|
||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: mlugg/setup-zig@v1 | ||
| with: | ||
| version: '0.13.0' | ||
| - working-directory: ./zig | ||
| run: zig fmt --check src test build.zig | ||
|
|
||
| lint-cpp: | ||
|
github-advanced-security[bot] marked this conversation as resolved.
Fixed
|
||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - run: sudo apt-get update && sudo apt-get install -y nlohmann-json3-dev clang-tidy clang-format | ||
| - working-directory: ./cpp | ||
| run: make lint | ||
|
|
||
| lint-cs: | ||
|
github-advanced-security[bot] marked this conversation as resolved.
Fixed
|
||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-dotnet@v4 | ||
| with: | ||
| dotnet-version: '8.0.x' | ||
| - working-directory: ./cs | ||
| run: dotnet build VoxgigStruct.csproj -warnaserror -nologo | ||
|
github-advanced-security[bot] marked this conversation as resolved.
Fixed
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.