Skip to content

Adding file config support for docker backend#32

Merged
ianhodge merged 1 commit intomainfrom
03-16-ian_yaml_config_file_support
Mar 18, 2026
Merged

Adding file config support for docker backend#32
ianhodge merged 1 commit intomainfrom
03-16-ian_yaml_config_file_support

Conversation

@ianhodge
Copy link
Member

@ianhodge ianhodge commented Mar 16, 2026

Adds a --config-file flag that allows reading of the self hosted worker config from a file rather than from flags

@ianhodge ianhodge marked this pull request as ready for review March 16, 2026 21:42
@ianhodge ianhodge changed the title adding stuff Adding file config support for docker backend Mar 16, 2026
@ianhodge ianhodge requested a review from bnavetta March 16, 2026 21:43
}

// BackendConfig contains the backend selection.
type BackendConfig struct {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be a followup, but we should use https://github.com/go-playground/validator to enforce requirements on the config, like only one backend being configured.

@ianhodge ianhodge force-pushed the 03-16-ian_yaml_config_file_support branch from 967e674 to f028895 Compare March 18, 2026 15:11
Base automatically changed from 03-10-ian_creating_backend_abstraction_for_self_hosted_worker to main March 18, 2026 15:21
@ianhodge ianhodge force-pushed the 03-16-ian_yaml_config_file_support branch from f028895 to 19c51d4 Compare March 18, 2026 18:07
@ianhodge ianhodge merged commit 4bef8cf into main Mar 18, 2026
4 checks passed
@ianhodge ianhodge deleted the 03-16-ian_yaml_config_file_support branch March 18, 2026 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants