Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refines the package distribution settings and adjusts the ESLint config path for publishing.
- Update
package.jsonto include the ESLint config file and attempt to exclude test files from the published package - Adjust import path in
eslint.config.publish.mjsto reflect the config’s new location
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Added "!dist/tests" (negation) and "eslint.config.publish.mjs" to the files array |
| eslint.config.publish.mjs | Changed plugin import from ../index.js to ./index.js |
Comments suppressed due to low confidence (2)
eslint.config.publish.mjs:5
- [nitpick] Update the comment to note that
index.jsshould now reside alongside this config file, reflecting its new root-level location.
import localPlugin from "./index.js"; // Assumes index.js is the entry point
package.json:30
- npm’s
filesfield does not support negation patterns (e.g.,"!dist/tests"). To excludedist/testsfrom the published package, remove this entry and instead adddist/teststo.npmignore.
"!dist/tests",
HerrCai0907
previously approved these changes
Jul 15, 2025
Changqing-JING
approved these changes
Jul 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix logic for publish.
Configuration updates:
eslint.config.publish.mjs: Renamed fromsample_config/sample_eslint.config.mjs, this is now part of the package distribution and made easier to access.Packaging updates:
package.json: Updated thefilesfield to includeeslint.config.publish.mjsand exclude unnecessarydist/testsfrom the package distribution.