Fix for test results not displaying in checks tab#1728
Fix for test results not displaying in checks tab#1728esimkowitz merged 4 commits intowavetermdev:mainfrom
Conversation
|
Warning Rate limit exceeded@chottuthejimmy has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 5 minutes and 31 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughThe pull request introduces modifications to the GitHub Actions workflow file The These modifications aim to improve workflow control and provide more detailed tracking of the test driver execution process. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/testdriver.yml(2 hunks)
🔇 Additional comments (2)
.github/workflows/testdriver.yml (2)
14-17: LGTM! Permissions are correctly configured.The added
actions: readpermission is necessary for accessing workflow run information, and the permission level is appropriately set to read-only.
50-50: LGTM! Good practice to gate test execution.The condition ensures that tests only run after a successful build, preventing unnecessary test runs on failed builds.
|
Hey @esimkowitz So github workflow_run triggers run in a separate pipeline that only knows the “completed” event from another workflow’s outcome; it doesn’t automatically attach itself to the original commit or PR.
in this PR I have tried to implement the former, unfortunately I was unable to test it on my fork branch. |
|
@esimkowitz I just saw this https://testdriver.canny.io/testdriver/p/implement-github-action-as-github-application |
|
I think those are all my comments, yeah I think the best long-term approach is to ditch the actions altogether. You can set up a server that listens to webhook events and updates the PR checks directly via the GitHub API using a GitHub App Token. I believe this is how CodeRabbit does their automated checks and we found it super painless to set up. We can check a file into our repo root that contains the TestDriver prompts and configs so you can pick it up in your system. Obviously not a short-term remedy, but food for thought as your product matures. |
|
Got it. That said, I think its gonna take a while for us to build that, given the fact that we are literally a two person team and got like a million other things, we are working super hard atm. So, if you could merge this for now and basically have a way to check it, would be great! Hope you understand Evan :) |
|
Of course! Yeah just some musings I had while I was waiting on the ski lift 🤣 |
|
I think there's a bug in my code. |
2 participants
No description provided.