fix directory scroll into view

[sawka]

No description provided.

[coderabbitai]

Walkthrough

The changes introduce enhancements to the DirectoryPreview component, focusing on keyboard navigation and scrolling logic. A new constant, PageJumpSize, is defined with a value of 20, which is utilized in the directoryKeyDownHandler function to allow navigation through the file list using the "PageUp" and "PageDown" keys. This adjustment modifies the focusIndex by the PageJumpSize when these keys are pressed. Furthermore, the scrolling logic in the TableBody component has been updated to determine the visibility of rows based on the current scroll position, incorporating a buffer of 30 pixels above and 5 pixels below the viewport. Minor refactoring has also been made to the handleFileContextMenu function, while its core functionality remains unchanged. The method signature for model.directoryKeyDownHandler has been updated to include the new key handling capabilities.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7999188 and 4671d33.

📒 Files selected for processing (1)

• frontend/app/view/preview/directorypreview.tsx (3 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: Analyze (javascript-typescript)
• GitHub Check: Build for TestDriver.ai
• GitHub Check: Analyze (go)

🔇 Additional comments (3)

frontend/app/view/preview/directorypreview.tsx (3)

34-34: LGTM! Well-defined constant for page navigation.

The constant value of 20 is reasonable for page-wise navigation through the directory listing.

---

498-513: LGTM! Enhanced scrolling logic with buffer zones.

The changes improve the scrolling behavior by:

• Using relative positioning to viewport for accurate calculations
• Adding buffer zones (30px above, 5px below) for smoother scrolling
• Ensuring the focused row remains visible with appropriate margins

---

780-787: LGTM! Well-implemented PageUp/PageDown navigation.

The implementation:

• Uses the PageJumpSize constant for consistent navigation distance
• Properly bounds the navigation within array limits using Math.max/min
• Follows the established pattern of keyboard event handling

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

frontend/app/view/preview/directorypreview.tsx (1)

778-785: Extract page jump size as a constant.

The PageUp/PageDown navigation is well implemented, but consider extracting the magic number 20 as a named constant for better maintainability.

+const PAGE_JUMP_SIZE = 20;
+
 if (checkKeyPressed(waveEvent, "PageUp")) {
-    setFocusIndex((idx) => Math.max(idx - 20, 0));
+    setFocusIndex((idx) => Math.max(idx - PAGE_JUMP_SIZE, 0));
     return true;
 }
 if (checkKeyPressed(waveEvent, "PageDown")) {
-    setFocusIndex((idx) => Math.min(idx + 20, filteredData.length - 1));
+    setFocusIndex((idx) => Math.min(idx + PAGE_JUMP_SIZE, filteredData.length - 1));
     return true;
 }

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between affd846 and 7999188.

📒 Files selected for processing (1)

• frontend/app/view/preview/directorypreview.tsx (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: Analyze (javascript-typescript)
• GitHub Check: Analyze (go)
• GitHub Check: Build for TestDriver.ai

🔇 Additional comments (1)

frontend/app/view/preview/directorypreview.tsx (1)

496-511: LGTM! Improved scrolling behavior with buffer zones.

The scrolling logic has been enhanced with better viewport calculations and buffer zones (30px above, 5px below) for smoother scrolling experience.