Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
88 commits
Select commit Hold shift + click to select a range
9fb41f0
add listentries
esimkowitz Feb 1, 2025
7791512
list entries implemented
esimkowitz Feb 1, 2025
1d804fa
more impls
esimkowitz Feb 2, 2025
91a936c
cat is working!
esimkowitz Feb 2, 2025
eeeedf6
save
esimkowitz Feb 2, 2025
b2ce931
fix "directory" handling for ls and rm
esimkowitz Feb 2, 2025
cd54d9b
save tar copy work
esimkowitz Feb 2, 2025
bafd175
save
esimkowitz Feb 2, 2025
8cb908f
copyremote initial impl, fix for wavefs
esimkowitz Feb 2, 2025
506fd72
save work
esimkowitz Feb 4, 2025
14c51cf
check dir walk error
esimkowitz Feb 4, 2025
09f3bce
save
esimkowitz Feb 4, 2025
92bb98e
add dir mode
esimkowitz Feb 5, 2025
24ac975
lots of fixes
esimkowitz Feb 6, 2025
b7c2444
Merge branch 'main' into evan/s3fs
esimkowitz Feb 6, 2025
4b610d3
add s3 trailing slash test
esimkowitz Feb 6, 2025
5b7cf86
add back quick add for pathtree
esimkowitz Feb 6, 2025
39cd7ce
Update pkg/util/fileutil/fileutil.go
esimkowitz Feb 6, 2025
297f400
fix readstream for s3
esimkowitz Feb 6, 2025
527e31d
Merge branch 'main' into evan/s3fs
esimkowitz Feb 6, 2025
97fdd52
Merge branch 'main' into evan/s3fs
esimkowitz Feb 7, 2025
0ae9ecd
bad merge
esimkowitz Feb 7, 2025
dc951dd
revert wshremote
esimkowitz Feb 7, 2025
c22a560
put back data close
esimkowitz Feb 7, 2025
264ff2d
fix empty file info error with readfilestream
esimkowitz Feb 7, 2025
db84722
Remove recursive from cp, make it default
esimkowitz Feb 8, 2025
5da7740
save
esimkowitz Feb 9, 2025
abb8e0d
save
esimkowitz Feb 9, 2025
e57f869
save
esimkowitz Feb 9, 2025
20badde
fix preceding slashes in tar headers
esimkowitz Feb 9, 2025
ad56f14
handle case where singleFile flag is set twice
esimkowitz Feb 9, 2025
b0ce1c2
update comment
esimkowitz Feb 9, 2025
62de973
Merge branch 'evan/copy-improvements' into evan/s3fs
esimkowitz Feb 9, 2025
b6a67d8
save
esimkowitz Feb 9, 2025
f56e189
remove s3 cp recursive flag, unnecessary context cancel
esimkowitz Feb 9, 2025
3c4aa68
more gracefulclose
esimkowitz Feb 9, 2025
4aa64c4
add traversal error
esimkowitz Feb 9, 2025
03ae872
apply suggestion
esimkowitz Feb 9, 2025
24b26ac
apply suggestion
esimkowitz Feb 9, 2025
5a512f4
apply suggestion
esimkowitz Feb 9, 2025
3102452
Merge branch 'main' into evan/s3fs
esimkowitz Feb 9, 2025
0e45087
add dirmode to wavefs
esimkowitz Feb 9, 2025
6582c63
Merge branch 'main' into evan/s3fs
esimkowitz Feb 9, 2025
4e01482
Merge branch 'main' into evan/s3fs
esimkowitz Feb 10, 2025
3840be3
remove logs, fix trailing slash in normalized filepath in dir preview
esimkowitz Feb 11, 2025
ff62039
save
esimkowitz Feb 11, 2025
6ace12a
save
esimkowitz Feb 11, 2025
c81ef48
Update pkg/remote/fileshare/s3fs/s3fs.go
esimkowitz Feb 11, 2025
afdb44d
Merge branch 'main' into evan/s3fs
esimkowitz Feb 11, 2025
501b79d
save
esimkowitz Feb 11, 2025
abed821
fix putfile
esimkowitz Feb 11, 2025
a74e1eb
fix putfile better
esimkowitz Feb 11, 2025
d75b7cd
fix parent dirs
esimkowitz Feb 12, 2025
c3714b3
Update pkg/remote/fileshare/fsutil/fsutil.go
esimkowitz Feb 12, 2025
9933e12
Update pkg/remote/fileshare/fsutil/fsutil.go
esimkowitz Feb 12, 2025
b63b196
clean up formatRemoteUri
esimkowitz Feb 12, 2025
9a0d3d9
fix local single file copy
esimkowitz Feb 12, 2025
9e1bed9
fix scrollintoview, also add pageup/pagedown handlers
sawka Feb 12, 2025
65fe8b1
save
esimkowitz Feb 12, 2025
efab0bf
fix propagation
sawka Feb 12, 2025
c98ef36
fix branch and drain channel fn
esimkowitz Feb 13, 2025
3ce3c24
more centralizing of the listEntries code
esimkowitz Feb 13, 2025
6111360
more notfound fixes
esimkowitz Feb 13, 2025
69577d2
save
esimkowitz Feb 13, 2025
654db39
save
esimkowitz Feb 13, 2025
73a86d0
save
esimkowitz Feb 14, 2025
59e3fb6
fix wavefs rm
esimkowitz Feb 14, 2025
de2e8e7
fix connparse for multiple slashes
esimkowitz Feb 14, 2025
91b594f
Merge branch 'main' into evan/s3fs
esimkowitz Feb 14, 2025
5091310
fix: revert fileContentAtom
oneirocosm Feb 14, 2025
70c23a8
test: fix behavior of test026
oneirocosm Feb 14, 2025
5470f9a
fix: copy dir behavior with target dir
oneirocosm Feb 14, 2025
c979dce
test: split up test 48 and 49
oneirocosm Feb 14, 2025
c590242
fix: revert getParentInfo and goParentDirectory
oneirocosm Feb 14, 2025
1a21231
fix dir in wshremote
esimkowitz Feb 15, 2025
ff0f5b7
merge main
sawka Feb 15, 2025
477f6e5
fix ~ path
sawka Feb 15, 2025
fd1d9ec
Revert "fix ~ path"
esimkowitz Feb 15, 2025
7e8e3ee
don't un-normalize path with home dir, fix display
esimkowitz Feb 15, 2025
ad89824
fix name
esimkowitz Feb 15, 2025
ebabb53
Revert "fix name"
esimkowitz Feb 15, 2025
e9c3ff8
Revert "Revert "fix ~ path""
esimkowitz Feb 15, 2025
f240949
Revert "don't un-normalize path with home dir, fix display"
esimkowitz Feb 15, 2025
ab05a3b
Merge branch 'main' into evan/s3revert
esimkowitz Feb 15, 2025
2191ca5
fix bad merge
esimkowitz Feb 15, 2025
b951ca1
fix bad .dir refs
esimkowitz Feb 15, 2025
9e17386
save
esimkowitz Feb 15, 2025
cd552b2
fix isdir
esimkowitz Feb 15, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/app/view/codeeditor/codeeditor.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ export function CodeEditor({ blockId, text, language, filename, fileinfo, meta,
const fileInfo = await RpcApi.RemoteFileJoinCommand(TabRpcClient, [filename], {
route: makeConnRoute(meta.connection ?? ""),
});
setAbsPath(`${fileInfo.dir}/${fileInfo.name}`);
setAbsPath(fileInfo.path);
} catch (e) {
setAbsPath(filename);
}
Expand Down
11 changes: 2 additions & 9 deletions frontend/app/view/preview/directorypreview.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -455,13 +455,6 @@ function DirectoryTable({
);
}

function getNormFilePath(finfo: FileInfo): string {
if (finfo.isdir) {
return finfo.dir;
}
return finfo.dir + "/" + finfo.name;
}

interface TableBodyProps {
bodyRef: React.RefObject<HTMLDivElement>;
model: PreviewModel;
Expand Down Expand Up @@ -525,7 +518,7 @@ function TableBody({
if (finfo == null) {
return;
}
const normPath = getNormFilePath(finfo);
const normPath = finfo.path;
const fileName = finfo.path.split("/").pop();
let parentFileInfo: FileInfo;
try {
Expand Down Expand Up @@ -618,7 +611,7 @@ function TableBody({
{
label: makeNativeLabel(PLATFORM, true, true),
click: () => {
getApi().openNativePath(parentFileInfo.dir);
getApi().openNativePath(parentFileInfo.path);
},
}
);
Expand Down
8 changes: 4 additions & 4 deletions frontend/app/view/preview/preview.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -751,7 +751,7 @@ export class PreviewModel implements ViewModel {
meta: {
view: "term",
controller: "shell",
"cmd:cwd": fileInfo.dir,
"cmd:cwd": fileInfo.path,
connection: conn,
},
};
Expand All @@ -764,7 +764,7 @@ export class PreviewModel implements ViewModel {
label: makeNativeLabel(PLATFORM, true, true),
click: async () => {
const fileInfo = await globalStore.get(this.statFile);
getApi().openNativePath(fileInfo.dir);
getApi().openNativePath(fileInfo.path);
},
});
}
Expand All @@ -775,7 +775,7 @@ export class PreviewModel implements ViewModel {
label: makeNativeLabel(PLATFORM, false, false),
click: async () => {
const fileInfo = await globalStore.get(this.statFile);
getApi().openNativePath(`${fileInfo.dir}/${fileInfo.name}`);
getApi().openNativePath(fileInfo.path);
},
});
}
Expand Down Expand Up @@ -1104,7 +1104,7 @@ const fetchSuggestions = async (
TabRpcClient,
{
suggestiontype: "file",
"file:cwd": fileInfo.dir,
"file:cwd": fileInfo.path,
query: query,
widgetid: reqContext.widgetid,
reqnum: reqContext.reqnum,
Expand Down
11 changes: 11 additions & 0 deletions pkg/wavebase/wavebase.go
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,17 @@ func ExpandHomeDirSafe(pathStr string) string {
return path
}

func ReplaceHomeDir(pathStr string) string {
homeDir := GetHomeDir()
if pathStr == homeDir {
return "~"
}
if strings.HasPrefix(pathStr, homeDir+"/") {
return "~" + pathStr[len(homeDir):]
}
return pathStr
}

func GetDomainSocketName() string {
return filepath.Join(GetWaveDataDir(), DomainSocketBaseName)
}
Expand Down
4 changes: 2 additions & 2 deletions pkg/wshrpc/wshremote/wshremote.go
Original file line number Diff line number Diff line change
Expand Up @@ -586,7 +586,7 @@ func (impl *ServerImpl) RemoteListEntriesCommand(ctx context.Context, data wshrp
func statToFileInfo(fullPath string, finfo fs.FileInfo, extended bool) *wshrpc.FileInfo {
mimeType := fileutil.DetectMimeType(fullPath, finfo, extended)
rtn := &wshrpc.FileInfo{
Path: fullPath,
Path: wavebase.ReplaceHomeDir(fullPath),
Dir: computeDirPart(fullPath),
Name: finfo.Name(),
Size: finfo.Size(),
Expand Down Expand Up @@ -644,7 +644,7 @@ func (*ServerImpl) fileInfoInternal(path string, extended bool) (*wshrpc.FileInf
finfo, err := os.Stat(cleanedPath)
if os.IsNotExist(err) {
return &wshrpc.FileInfo{
Path: path,
Path: wavebase.ReplaceHomeDir(path),
Dir: computeDirPart(path),
NotFound: true,
ReadOnly: checkIsReadOnly(cleanedPath, finfo, false),
Expand Down
Loading