Skip to content

add a key to specializedviewcomponent so that we don't get stale content displayed #1981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sawka merged 1 commit into from
Feb 17, 2025
Merged

add a key to specializedviewcomponent so that we don't get stale content displayed #1981

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion frontend/app/view/preview/preview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1075,6 +1075,7 @@ const SpecializedView = memo(({ parentRef, model }: SpecializedViewProps) => {
const specializedView = useAtomValue(model.specializedView);
const mimeType = useAtomValue(model.fileMimeType);
const setCanPreview = useSetAtom(model.canPreview);
const path = useAtomValue(model.statFilePath);

useEffect(() => {
setCanPreview(canPreview(mimeType));
Expand All @@ -1087,7 +1088,7 @@ const SpecializedView = memo(({ parentRef, model }: SpecializedViewProps) => {
if (!SpecializedViewComponent) {
return <CenteredDiv>Invalid Specialzied View Component ({specializedView.specializedView})</CenteredDiv>;
}
return <SpecializedViewComponent model={model} parentRef={parentRef} />;
return <SpecializedViewComponent key={path} model={model} parentRef={parentRef} />;
});

const fetchSuggestions = async (
Expand Down
Loading