Skip to content

update modal buttons #1993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sawka merged 1 commit into from
Feb 19, 2025
Merged

update modal buttons #1993

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 18 additions & 13 deletions frontend/app/modals/about.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
// SPDX-License-Identifier: Apache-2.0

import Logo from "@/app/asset/logo.svg";
import { LinkButton } from "@/app/element/linkbutton";
import { modalsModel } from "@/app/store/modalmodel";
import { Modal } from "./modal";

Expand Down Expand Up @@ -37,24 +36,30 @@ const AboutModal = ({}: AboutModalProps) => {
Update Channel: {updaterChannel}
</div>
<div className="section links">
<LinkButton
className="secondary solid"
<a
href="https://github.com/wavetermdev/waveterm"
target="_blank"
rel="noopener"
className="inline-flex items-center px-4 py-2 rounded border border-border hover:bg-hoverbg transition-colors duration-200"
>
<i className="fa-brands fa-github"></i>Github
</LinkButton>
<LinkButton className="secondary solid" href="https://www.waveterm.dev/" target="_blank">
<i className="fa-sharp fa-light fa-globe"></i>Website
</LinkButton>
<LinkButton
className="secondary solid"
<i className="fa-brands fa-github mr-2"></i>Github
</a>
<a
href="https://www.waveterm.dev/"
target="_blank"
rel="noopener"
className="inline-flex items-center px-4 py-2 rounded border border-border hover:bg-hoverbg transition-colors duration-200"
>
<i className="fa-sharp fa-light fa-globe mr-2"></i>Website
</a>
<a
href="https://github.com/wavetermdev/waveterm/blob/main/ACKNOWLEDGEMENTS.md"
target="_blank"
rel={"noopener"}
rel="noopener"
className="inline-flex items-center px-4 py-2 rounded border border-border hover:bg-hoverbg transition-colors duration-200"
>
<i className="fa-sharp fa-light fa-heart"></i>Acknowledgements
</LinkButton>
<i className="fa-sharp fa-light fa-heart mr-2"></i>Acknowledgements
</a>
Comment on lines +39 to +62
Copy link
Contributor

@coderabbitai coderabbitai bot Feb 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Enhance security and accessibility for external links.

While using rel="noopener" is good, external links need additional security and accessibility improvements:

Apply this diff to all three anchor tags:

   <a
     href="..."
     target="_blank"
-    rel="noopener"
+    rel="noopener noreferrer"
+    aria-label="Opens in new tab"
     className="..."
   >
-    <i className="..."></i>Github
+    <i className="..."></i>Github <span className="sr-only">(Opens in new tab)</span>
   </a>
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<a
href="https://github.com/wavetermdev/waveterm"
target="_blank"
rel="noopener"
className="inline-flex items-center px-4 py-2 rounded border border-border hover:bg-hoverbg transition-colors duration-200"
>
<i className="fa-brands fa-github"></i>Github
</LinkButton>
<LinkButton className="secondary solid" href="https://www.waveterm.dev/" target="_blank">
<i className="fa-sharp fa-light fa-globe"></i>Website
</LinkButton>
<LinkButton
className="secondary solid"
<i className="fa-brands fa-github mr-2"></i>Github
</a>
<a
href="https://www.waveterm.dev/"
target="_blank"
rel="noopener"
className="inline-flex items-center px-4 py-2 rounded border border-border hover:bg-hoverbg transition-colors duration-200"
>
<i className="fa-sharp fa-light fa-globe mr-2"></i>Website
</a>
<a
href="https://github.com/wavetermdev/waveterm/blob/main/ACKNOWLEDGEMENTS.md"
target="_blank"
rel={"noopener"}
rel="noopener"
className="inline-flex items-center px-4 py-2 rounded border border-border hover:bg-hoverbg transition-colors duration-200"
>
<i className="fa-sharp fa-light fa-heart"></i>Acknowledgements
</LinkButton>
<i className="fa-sharp fa-light fa-heart mr-2"></i>Acknowledgements
</a>
<a
href="https://github.com/wavetermdev/waveterm"
target="_blank"
rel="noopener noreferrer"
aria-label="Opens in new tab"
className="inline-flex items-center px-4 py-2 rounded border border-border hover:bg-hoverbg transition-colors duration-200"
>
<i className="fa-brands fa-github mr-2"></i>Github <span className="sr-only">(Opens in new tab)</span>
</a>
<a
href="https://www.waveterm.dev/"
target="_blank"
rel="noopener noreferrer"
aria-label="Opens in new tab"
className="inline-flex items-center px-4 py-2 rounded border border-border hover:bg-hoverbg transition-colors duration-200"
>
<i className="fa-sharp fa-light fa-globe mr-2"></i>Website <span className="sr-only">(Opens in new tab)</span>
</a>
<a
href="https://github.com/wavetermdev/waveterm/blob/main/ACKNOWLEDGEMENTS.md"
target="_blank"
rel="noopener noreferrer"
aria-label="Opens in new tab"
className="inline-flex items-center px-4 py-2 rounded border border-border hover:bg-hoverbg transition-colors duration-200"
>
<i className="fa-sharp fa-light fa-heart mr-2"></i>Acknowledgements <span className="sr-only">(Opens in new tab)</span>
</a>

</div>
<div className="section text-standard">&copy; {currentDate.getFullYear()} Command Line Inc.</div>
</div>
Expand Down
Loading