Fix regression not showing .. dir

[esimkowitz]

No description provided.

[coderabbitai]

Walkthrough

The changes update the handling of directory entries in a function that reads directory contents. Specifically, the code now uses optional chaining when accessing the entries property by changing from file.entries ?? [] to file?.entries ?? []. This ensures that if the file object is null or undefined, the code assigns an empty array to entries, avoiding potential errors. Additionally, a new entry representing the parent directory is added at the beginning of the entries list. This entry is characterized by a name of "..", a path derived from the file's directory information, a flag indicating it is a directory (isdir set to true), a modification time set to the current timestamp, and a mimetype labeled as "directory". Error handling remains the same, and no adjustments were made to the exported or public entities.

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

frontend/app/view/preview/directorypreview.tsx (1)

793-799: LGTM! Consider handling edge cases.

Adding the parent directory entry is a good UX improvement. The implementation correctly sets all necessary properties and uses optional chaining for safety.

Consider these improvements:

1. Validate if parent directory exists/is accessible
2. Handle root directory case where ".." might not be needed

 entries.unshift({
     name: "..",
-    path: file?.info?.dir,
+    path: file?.info?.dir && file.info.dir !== file.info.path ? file.info.dir : null,
     isdir: true,
     modtime: new Date().getTime(),
     mimetype: "directory",
 });

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f60d0f0 and f8a4d87.

📒 Files selected for processing (1)

• frontend/app/view/preview/directorypreview.tsx (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: Analyze (javascript-typescript)
• GitHub Check: Build for TestDriver.ai
• GitHub Check: Analyze (go)

🔇 Additional comments (1)

frontend/app/view/preview/directorypreview.tsx (1)

792-792: LGTM! Good defensive programming practice.

The addition of optional chaining (?.) provides better null safety by ensuring that if file is null or undefined, the code gracefully falls back to an empty array.