Skip to content

fix issue with directory "oversearch" causing an error with pinned rows #2134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sawka merged 1 commit into from
Apr 28, 2025
Merged

fix issue with directory "oversearch" causing an error with pinned rows #2134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions frontend/app/element/errorboundary.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ export class ErrorBoundary extends React.Component<
}

componentDidCatch(error: Error, errorInfo: React.ErrorInfo) {
console.log("ErrorBoundary caught an error:", error, errorInfo);
this.setState({ error: error });
}

Expand Down
10 changes: 9 additions & 1 deletion frontend/app/view/preview/directorypreview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,12 +385,20 @@ function DirectoryTable({

useLayoutEffect(() => {
const rows = table.getRowModel()?.flatRows;
let foundParentDir = false;

for (const row of rows) {
if (row.getValue("name") == "..") {
row.pin("top");
return;
foundParentDir = true;
break;
}
}

// If we didn't find the ".." row, reset the pinning to avoid stale references
if (!foundParentDir) {
table.resetRowPinning();
}
}, [table, data]);
const columnSizeVars = useMemo(() => {
const headers = table.getFlatHeaders();
Expand Down
Loading