Skip to content

move tsunami views to webviews. also fix git+ssh urls in package-lock.json#2355

Merged
sawka merged 1 commit intomainfrom
sawka/tsunami-view-2
Sep 16, 2025
Merged

move tsunami views to webviews. also fix git+ssh urls in package-lock.json#2355
sawka merged 1 commit intomainfrom
sawka/tsunami-view-2

Conversation

@sawka
Copy link
Member

@sawka sawka commented Sep 16, 2025

…k.json ...

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 16, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The Tsunami view was refactored from iframe-based rendering to a WebView-based implementation. TsunamiViewModel now extends WebViewModel, leveraging inherited properties and adding configuration for hideNav and partitionOverride. The public React component export for TsunamiView was removed; only TsunamiViewModel is exported. WebView gained support for an initialSrc to control first-load behavior and a partition override read via a new useAtomValueSafe utility. WebViewModel added a partitionOverride member and a loadUrlPromise method. Settings menu item filtering was adjusted, and basic configuration validation was added to render an inline error when required parameters are missing.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch sawka/tsunami-view-2

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9dd216a and f685d3c.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (2)
  • frontend/app/view/tsunami/tsunami.tsx (3 hunks)
  • frontend/app/view/webview/webview.tsx (8 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sawka sawka changed the title move tsunami views to webviews. also fix git+ssh urls in package-loc… move tsunami views to webviews. also fix git+ssh urls in package-lock.json Sep 16, 2025
@sawka sawka merged commit fb41254 into main Sep 16, 2025
4 of 7 checks passed
@sawka sawka deleted the sawka/tsunami-view-2 branch September 16, 2025 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant