-
-
Notifications
You must be signed in to change notification settings - Fork 807
custom streamdown components for wave ai #2404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
5b21346
new streamdown impl... shiki, custom styling fixes, etc
sawka fcbc32b
fix more rendering issues... codeblocks, headers
sawka fe4c940
fix first child top margins...
sawka 95149a5
better highlighting, less flashing on render
sawka 52fd944
placeholder streamdown text
sawka 80978c6
more reliable scroll to bottom after loading messages
sawka cee6fd4
constrain code blocks to be max width. prevents panel horizontal scr…
sawka dbe823c
throttle shiki formatting, fix remount issue with streamdown.
sawka 3e1dd37
more robust extract text
sawka File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clean up setTimeout on unmount.
If the component unmounts during the 100ms delay, the timeout will still fire and attempt to call
model.scrollToBottom(). Store the timeout ID and clear it in the cleanup function:useEffect(() => { const loadMessages = async () => { const messages = await model.loadChat(); setMessages(messages as any); setIsLoadingChat(false); - setTimeout(() => { + const timeoutId = setTimeout(() => { model.scrollToBottom(); }, 100); + return () => clearTimeout(timeoutId); }; loadMessages(); }, [model, setMessages]);🤖 Prompt for AI Agents