Skip to content

fix wave ai scrolling bug (and some other small UI fixes) #2416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sawka merged 2 commits into from
Oct 10, 2025
Merged

fix wave ai scrolling bug (and some other small UI fixes) #2416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43c4772
fix ai messages scrolling
sawka Oct 10, 2025
d390e70
use success/error colors
sawka Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions frontend/app/aipanel/aimessage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,11 +79,7 @@ const AIToolUse = memo(({ part }: AIToolUseProps) => {

const statusIcon = toolData.status === "completed" ? "✓" : toolData.status === "error" ? "✗" : "•";
const statusColor =
toolData.status === "completed"
? "text-green-400"
: toolData.status === "error"
? "text-red-400"
: "text-gray-400";
toolData.status === "completed" ? "text-success" : toolData.status === "error" ? "text-error" : "text-gray-400";

const effectiveApproval = userApprovalOverride || toolData.approval;

Expand Down
4 changes: 1 addition & 3 deletions frontend/app/aipanel/aipanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,9 +528,7 @@ const AIPanelComponentInner = memo(({ className, onClose }: AIPanelProps) => {
<AIWelcomeMessage />
</div>
) : (
<div className="flex-1 min-h-0" onContextMenu={handleMessagesContextMenu}>
<AIPanelMessages messages={messages} status={status} />
</div>
<AIPanelMessages messages={messages} status={status} onContextMenu={handleMessagesContextMenu} />
)}
{errorMessage && (
<AIErrorMessage errorMessage={errorMessage} onClear={() => model.clearError()} />
Expand Down
5 changes: 3 additions & 2 deletions frontend/app/aipanel/aipanelmessages.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,10 @@ import { WaveAIModel } from "./waveai-model";
interface AIPanelMessagesProps {
messages: any[];
status: string;
onContextMenu?: (e: React.MouseEvent) => void;
}

export const AIPanelMessages = memo(({ messages, status }: AIPanelMessagesProps) => {
export const AIPanelMessages = memo(({ messages, status, onContextMenu }: AIPanelMessagesProps) => {
const model = WaveAIModel.getInstance();
const isPanelOpen = useAtomValue(WorkspaceLayoutModel.getInstance().panelVisibleAtom);
const messagesEndRef = useRef<HTMLDivElement>(null);
Expand Down Expand Up @@ -41,7 +42,7 @@ export const AIPanelMessages = memo(({ messages, status }: AIPanelMessagesProps)
}, [isPanelOpen]);

return (
<div ref={messagesContainerRef} className="flex-1 overflow-y-auto p-2 space-y-4">
<div ref={messagesContainerRef} className="flex-1 overflow-y-auto p-2 space-y-4" onContextMenu={onContextMenu}>
{messages.map((message, index) => {
const isLastMessage = index === messages.length - 1;
const isStreaming = status === "streaming" && isLastMessage && message.role === "assistant";
Expand Down
2 changes: 1 addition & 1 deletion frontend/app/element/streamdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ const CodeBlock = ({ children, onClickExecute, codeBlockMaxWidthAtom }: CodeBloc
return (
<div
className={cn("rounded-lg overflow-hidden bg-black my-4", codeBlockMaxWidth && "max-w-full")}
style={codeBlockMaxWidth ? { maxWidth: `${codeBlockMaxWidth}px` } : undefined}
style={codeBlockMaxWidth ? { maxWidth: codeBlockMaxWidth, minWidth: Math.min(400, codeBlockMaxWidth) } : undefined}
>
<div className="flex items-center justify-between pl-3 pr-2 pt-2 pb-1.5">
<span className="text-[11px] text-white/50">{language}</span>
Expand Down
Loading