Skip to content

Fix IME inputs for Wave AI, and update privacy wording to be more clear about OpenAI#2466

Merged
sawka merged 3 commits intomainfrom
sawka/fix-ime
Oct 21, 2025
Merged

Fix IME inputs for Wave AI, and update privacy wording to be more clear about OpenAI#2466
sawka merged 3 commits intomainfrom
sawka/fix-ime

Conversation

@sawka
Copy link
Member

@sawka sawka commented Oct 21, 2025

Fix for #2385 for Wave AI.

Also update privacy information to say we send the chats to OpenAI for processing.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 21, 2025

Walkthrough

This pull request updates privacy documentation to reference OpenAI's privacy policy, implements composition-aware Enter key handling in the AI panel input component to prevent accidental submissions during IME input, and expands the system prompt with explicit messaging that shell commands, terminal execution, and file editing capabilities are unavailable. Changes span documentation files, TypeScript components, and Go configuration code with no modifications to exported public APIs.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Rationale: The changes are moderately heterogeneous across four files with mixed complexity. Two documentation updates require verification of messaging consistency and accuracy (~8 minutes). The IME composition-aware keyboard handler involves specific event handling logic that requires understanding keyboard events, composition states, and edge cases (~12 minutes). The system prompt expansion is straightforward text addition but affects runtime AI behavior and messaging (~5 minutes). No complex structural changes, but the variety of file types and behavioral implications warrant careful review.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The PR title "Fix IME inputs for Wave AI, and update privacy wording to be more clear about OpenAI" directly captures the main changes in the changeset. The IME input fix is clearly reflected in the aipanelinput.tsx changes that add composition-aware handling for the Enter key. The privacy wording updates are evident in both the docs/waveai.mdx and telemetryrequired.tsx files, which now reference OpenAI's privacy policy. The title is specific, concise, and accurately summarizes the primary changes without requiring excessive detail.
Description Check ✅ Passed The PR description is directly related to the changeset, mentioning the GitHub issue fix for Wave AI (issue #2385, which concerns IME input handling) and referencing the privacy information updates about sending chats to OpenAI for processing. While the description is brief and doesn't mention every modification (such as the system prompt update in usechat.go), it covers the core objectives and is clearly on-topic and relevant to the changes being made.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch sawka/fix-ime

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.5.0)

Error: unknown linters: 'unusedfunc,unusedparams', run 'golangci-lint help linters' to see the list of supported linters
The command is terminated due to an error: unknown linters: 'unusedfunc,unusedparams', run 'golangci-lint help linters' to see the list of supported linters


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
frontend/app/aipanel/aipanelinput.tsx (1)

54-60: IME composition handling looks good!

The implementation correctly prevents premature submission during IME composition by checking both isComposing and the keyCode 229 fallback. This should resolve the reported IME input issue.

Minor style suggestion: Consider using strict equality for the keyCode check:

-        const isComposing = e.nativeEvent?.isComposing || e.keyCode == 229;
+        const isComposing = e.nativeEvent?.isComposing || e.keyCode === 229;
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e510f35 and 3929941.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (4)
  • docs/docs/waveai.mdx (1 hunks)
  • frontend/app/aipanel/aipanelinput.tsx (1 hunks)
  • frontend/app/aipanel/telemetryrequired.tsx (1 hunks)
  • pkg/aiusechat/usechat.go (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Build for TestDriver.ai
  • GitHub Check: Analyze (go)
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: merge-gatekeeper
🔇 Additional comments (3)
docs/docs/waveai.mdx (1)

64-69: Privacy disclosure is clear and appropriate.

The updated messaging properly discloses that messages are processed through OpenAI's APIs and directs users to the relevant privacy policy. This aligns well with the PR objective to be more transparent about OpenAI usage.

pkg/aiusechat/usechat.go (1)

87-93: System prompt updates appropriately manage user expectations.

The added guidance clearly communicates current limitations (no shell commands, terminal execution, file edits, or remote reads) and instructs the AI to offer practical alternatives via copy-paste. This should help reduce user frustration and improve the overall experience.

frontend/app/aipanel/telemetryrequired.tsx (1)

59-62: Privacy messaging is consistent and transparent.

The updated text clearly discloses that Wave AI uses OpenAI's APIs and appropriately directs users to OpenAI's privacy policy. This is consistent with the documentation update in docs/docs/waveai.mdx.

@sawka sawka merged commit 6781ae4 into main Oct 21, 2025
9 checks passed
@sawka sawka deleted the sawka/fix-ime branch October 21, 2025 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant