simplify table rendering (no more pinned rows nonsense) to fix #2513

[sawka]

No description provided.

[coderabbitai]

Walkthrough

This pull request refactors table row handling in the preview directory component and adds an indirect dependency. In the frontend, the changes remove explicit row pinning configuration and the useLayoutEffect hook that managed pinning logic. Row data access switches from combining top/center row groups to using table.getRowModel()?.flatRows for a flat structure. The ".." parent-directory row is now rendered separately with hardcoded index 0, while subsequent row indices are conditionally adjusted to account for its presence. The go.mod file receives an indirect dependency addition for github.com/outrigdev/goid v0.3.0.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20–25 minutes

• Row rendering logic verification: The new separate rendering of the ".." row and conditional index adjustments require careful testing to ensure correct display and interaction in all scenarios (with/without parent directory)
• Data access pattern change: The switch from combining row groups to using table.getRowModel()?.flatRows needs validation that all rows are properly retrieved
• Dependency addition context: The purpose and necessity of adding the indirect goid dependency should be clarified

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.
Description check	❓ Inconclusive	No pull request description was provided by the author.	Add a description explaining the motivation, implementation approach, and why this change fixes the referenced issue.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the main change: simplifying table rendering by removing pinned rows, and references the issue it fixes.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch sawka/fix-dirtable

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7437199 and f084889.

⛔ Files ignored due to path filters (1)

• go.sum is excluded by !**/*.sum

📒 Files selected for processing (2)

• frontend/app/view/preview/preview-directory.tsx (4 hunks)
• go.mod (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: Analyze (go)
• GitHub Check: Build for TestDriver.ai
• GitHub Check: Analyze (javascript-typescript)

🔇 Additional comments (2)

frontend/app/view/preview/preview-directory.tsx (1)

28-28: LGTM - Import cleanup aligns with refactoring.

Removing useLayoutEffect is appropriate since the row pinning logic it supported has been eliminated.

go.mod (1)

83-83: Dependency is intentional and secure—no action required.

The github.com/outrigdev/goid package is actively imported in git/tsunami/engine/globalctx.go, confirming this is an intentional, not spurious, dependency. No security vulnerabilities were found for this version. The PR likely includes backend infrastructure changes beyond the stated frontend objectives.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}