Conversation
Co-authored-by: sawka <2722291+sawka@users.noreply.github.com>
Deploying waveterm with
|
| Latest commit: |
4db8c15
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8c2c280a.waveterm.pages.dev |
| Branch Preview URL: | https://copilot-add-wsh-debugterm-co.waveterm.pages.dev |
Co-authored-by: sawka <2722291+sawka@users.noreply.github.com>
Co-authored-by: sawka <2722291+sawka@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add hidden wsh debugterm command for terminal output
Add hidden Feb 27, 2026
wsh debugterm command for terminal tail byte inspection (hex/decode)
Co-authored-by: sawka <2722291+sawka@users.noreply.github.com>
Co-authored-by: sawka <2722291+sawka@users.noreply.github.com>
Co-authored-by: sawka <2722291+sawka@users.noreply.github.com>
Copilot
AI
changed the title
Add hidden
Add Feb 27, 2026
wsh debugterm command for terminal tail byte inspection (hex/decode)wsh debugterm --mode stdin to decode FE-emitted JSON string arrays
wsh debugterm --mode stdin to decode FE-emitted JSON string arrayswsh debugterm
| if readSize > dataLength { | ||
| readSize = dataLength | ||
| } | ||
| readOffset := waveFile.Size - readSize |
Contributor
There was a problem hiding this comment.
CRITICAL: Incorrect offset calculation for circular files
This line uses waveFile.Size - readSize which is incorrect for circular files. When a terminal file is circular and Size > MaxSize, this calculation will produce an offset beyond the actual available data.
The correct calculation should account for the data start index:
readOffset := waveFile.DataStartIdx() + dataLength - readSizeThis ensures:
- For regular files:
DataStartIdx()returns 0, so it becomesdataLength - readSize(equivalent toSize - readSize) - For circular files: It correctly accounts for the starting index of available data, preventing out-of-bounds reads
Contributor
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)CRITICAL
Files Reviewed (6 files)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wsh debugtermcurrently decodes terminal bytes sourced from backend block files. This extends it with a stdin-driven path so FE-emitted payloads like["...", "..."]can be decoded directly without requiring block lookup/RPC in that mode.CLI surface
--mode stdinhex,decode,stdingetDebugTermMode()Execution path split
debugTermPreRun):stdinmode: skips RPC setuphex/decode: keeps existing RPC setup behaviorstdinmode now:[]stringParsing support
parseDebugTermStdinData([]byte) ([]byte, error)Tests
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.