fix(config): restore anthropic-messages APIType enum#2968
fix(config): restore anthropic-messages APIType enum#29681WorldCapture wants to merge 2 commits intowavetermdev:mainfrom
Conversation
The anthropic-messages API type was accidentally removed from the jsonschema enum in PR #2602 when Google Gemini backend was added. This restores it so users can configure Anthropic Claude models through the UI. Backend support for anthropic-messages was already complete in pkg/aiusechat/anthropic/, only the schema enum was missing.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Repository UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThis change adds "anthropic-messages" to the AIModeConfigType ai:apitype enum. The update is made in two files: Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Other Observations (not in diff)Issues found in unchanged code that cannot receive inline comments:
Files Reviewed (2 files)
AnalysisThe PR correctly adds However, there's a potential issue in the frontend code where |
|
|
|
Ah, unfortunately the anthropic messages API is not actually done (that's why it was removed). It is about 80% complete and hasn't been kept up-to-date. For now, if you want to use anthropic models you'll have to use an aggregator like openrouter. |
|
got it, thanks for your info. @sawka |
Summary
This PR restores
anthropic-messagesin theai:apitypeJSON schema enum so Anthropic Claude modes can be configured via settings/UI again.Background
In PR #2602 (Gemini backend addition),
anthropic-messageswas accidentally removed from the API type enum definitions.Backend support for Anthropic messages remained intact in
pkg/aiusechat/anthropic/, but configuration validation/schema no longer allowed selecting that API type.Changes
anthropic-messagesback toAIModeConfigType.APITypejsonschema enum in:pkg/wconfig/settingsconfig.goanthropic-messagesback to generated schema enum in:schema/waveai.jsonImpact
Testing