Skip to content

Add builder-launch strip to AppsFloatingWindow#2979

Merged
sawka merged 3 commits intomainfrom
copilot/add-ghost-button-to-floating-window
Mar 5, 2026
Merged

Add builder-launch strip to AppsFloatingWindow#2979
sawka merged 3 commits intomainfrom
copilot/add-ghost-button-to-floating-window

Conversation

Copy link
Contributor

Copilot AI commented Mar 4, 2026

AppsFloatingWindow currently lists local apps but does not provide an in-context way to open the app builder picker. This change adds a bottom ghost-style action strip (+ Build/Edit Apps) that launches the builder via Electron preload with openBuilder(null).

  • What changed

    • Added a new bottom strip action inside AppsFloatingWindow:
      • Label: + Build/Edit Apps
      • Visual style: ghost-like footer strip with top border, hover state, full-width click target
    • Wired the strip to call the preload API and close the floating window:
      • getApi().openBuilder(null) (null app id opens the app picker)
    • Kept the change scoped to frontend/app/workspace/widgets.tsx with no behavior changes to app-grid item launching.
  • Implementation detail

    • Imported getApi from @/store/global
    • Added a memoized handler for builder launch:
const handleOpenBuilder = useCallback(() => {
    getApi().openBuilder(null);
    onClose();
}, [onClose]);

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: sawka <2722291+sawka@users.noreply.github.com>
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Mar 4, 2026

Deploying waveterm with  Cloudflare Pages  Cloudflare Pages

Latest commit: f1f6a20
Status: ✅  Deploy successful!
Preview URL: https://da5eb20d.waveterm.pages.dev
Branch Preview URL: https://copilot-add-ghost-button-to.waveterm.pages.dev

View logs

Copilot AI changed the title [WIP] Add ghost-like button to AppsFloatingWindow Add builder-launch strip to AppsFloatingWindow Mar 4, 2026
Copilot finished work on behalf of sawka March 4, 2026 21:48
@sawka sawka marked this pull request as ready for review March 4, 2026 22:39
@kilo-code-bot
Copy link
Contributor

kilo-code-bot bot commented Mar 4, 2026

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 file)
  • frontend/app/workspace/widgets.tsx - Adds "Build/Edit Apps" button to floating apps window

Review Notes

The changes properly implement a new "Build/Edit Apps" button at the bottom of the apps floating window:

Correct API usage: getApi().openBuilder(null) matches the ElectronApi interface definition
Proper React patterns: Uses useCallback with correct dependencies [onClose]
Good UX: Button is styled consistently with the rest of the UI and properly closes the window after action
Clean structure: Content is properly wrapped in a padded container with the button as a footer element
Accessibility: Button has proper type="button" attribute

The implementation follows Wave Terminal's coding conventions and integrates well with the existing codebase.

@sawka sawka merged commit 9d4acb7 into main Mar 5, 2026
10 checks passed
@sawka sawka deleted the copilot/add-ghost-button-to-floating-window branch March 5, 2026 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants