Skip to content

Update aiusechat read_dir tests for typed entry output #3007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sawka merged 2 commits into from
Mar 7, 2026
Merged

Update aiusechat read_dir tests for typed entry output #3007

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70111a9
Initial plan
Copilot Mar 7, 2026
f062674
test: fix read_dir callback expectations
Copilot Mar 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions pkg/aiusechat/tools_readdir_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import (
"testing"

"github.com/wavetermdev/waveterm/pkg/aiusechat/uctypes"
"github.com/wavetermdev/waveterm/pkg/util/fileutil"
)

func TestReadDirCallback(t *testing.T) {
Expand Down Expand Up @@ -64,16 +65,16 @@ func TestReadDirCallback(t *testing.T) {
t.Errorf("Expected 3 entries, got %d", entryCount)
}

entries, ok := resultMap["entries"].([]map[string]any)
entries, ok := resultMap["entries"].([]fileutil.DirEntryOut)
if !ok {
t.Fatalf("entries is not a slice of maps")
t.Fatalf("entries is not a slice of DirEntryOut")
}

// Check that we have the expected entries
foundFiles := 0
foundDirs := 0
for _, entry := range entries {
if entry["is_dir"].(bool) {
if entry.Dir {
foundDirs++
} else {
foundFiles++
Expand Down Expand Up @@ -208,12 +209,15 @@ func TestReadDirSortBeforeTruncate(t *testing.T) {
}

resultMap := result.(map[string]any)
entries := resultMap["entries"].([]map[string]any)
entries, ok := resultMap["entries"].([]fileutil.DirEntryOut)
if !ok {
t.Fatalf("entries is not a slice of DirEntryOut")
}

// Count directories in the result
dirCount := 0
for _, entry := range entries {
if entry["is_dir"].(bool) {
if entry.Dir {
dirCount++
}
}
Expand All @@ -225,7 +229,7 @@ func TestReadDirSortBeforeTruncate(t *testing.T) {

// First 3 entries should be directories
for i := 0; i < 3; i++ {
if !entries[i]["is_dir"].(bool) {
if !entries[i].Dir {
t.Errorf("Expected entry %d to be a directory, but it was a file", i)
}
}
Expand Down
Loading