Add tests for WikiUserEmailChecker#1036
Merged
AndrewKostka merged 7 commits intomainfrom Jan 19, 2026
Merged
Conversation
rosalieper
reviewed
Jan 16, 2026
| use Illuminate\Foundation\Testing\RefreshDatabase; | ||
|
|
||
| class WikiUserEmailCheckerTest extends TestCase { | ||
| use RefreshDatabase; |
Contributor
There was a problem hiding this comment.
Is RefreshDatabase actually used? the test creates and delete databases using PDO.
rosalieper
reviewed
Jan 16, 2026
Contributor
rosalieper
left a comment
rosalieper
left a comment
There was a problem hiding this comment.
LGTM. I suggest removing the RefreshDatabase as the db effects are not handled by laravel eloquent models, this can be confusing.
I am happy with this moving foward in any case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: T410856