fix: prevent orphaned ALB target groups and improve Jupyter URL handling#12
Open
wdvr wants to merge 1 commit into
Open
fix: prevent orphaned ALB target groups and improve Jupyter URL handling#12wdvr wants to merge 1 commit into
wdvr wants to merge 1 commit into
Conversation
Root cause: ALB target groups were created but never cleaned up when: 1. Listener rule creation failed (100 target group limit) 2. jupyter_port was 0 (Jupyter disabled) causing "Invalid port" errors 3. Expiry Lambda cleanup was failing silently Changes: - Skip ALB setup if jupyter_port is 0 (Jupyter disabled) - Clean up target group if listener rule creation fails - Add cleanup_orphaned_target_groups() function to alb_utils.py - Call orphaned TG cleanup from expiry Lambda on each run - Use IP:port fallback instead of broken domain:port when ALB fails Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
b7ffe3b to
5d24adc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause Analysis
ALB target groups were accumulating because:
CloudWatch Evidence
Test plan
tf apply🤖 Generated with Claude Code