fix: pin actions to SHA, npm audit fix, add CODEOWNERS#72
Open
magnonta wants to merge 2 commits into
Open
Conversation
- Pin all GitHub Actions to commit SHA across test, release, and pages workflows - Run npm audit fix (0 vulnerabilities remaining) - Add CODEOWNERS with @magnonta and @cayohollanda
magnonta
added
security
There was a problem hiding this comment.
Pull request overview
This PR hardens the repository’s supply chain posture by pinning GitHub Actions to immutable SHAs, updating the npm dependency tree via npm audit fix, and introducing CODEOWNERS for default review routing.
Changes:
- Pin all GitHub Actions in CI/release/pages workflows to commit SHAs (with version comments retained).
- Update
package-lock.jsonto addressnpm auditvulnerabilities and refresh transitive dependencies. - Add a default
.github/CODEOWNERSfile to assign reviewers.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
package-lock.json |
Updates the lockfile dependency graph after npm audit fix. |
.github/workflows/test.yml |
Pins CI workflow actions to SHAs. |
.github/workflows/release.yml |
Pins release workflow actions to SHAs. |
.github/workflows/pages.yml |
Pins Pages workflow actions to SHAs. |
.github/CODEOWNERS |
Adds default code ownership for review assignment. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Addresses Copilot review: --package-lock=false was bypassing the lockfile, making CI non-reproducible and ignoring the audited dependency graph. Switched to npm ci which enforces the lockfile. Removed --omit=peer as npm ci handles peer deps correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pin all GitHub Actions to commit SHA, fix npm audit vulnerabilities, and add CODEOWNERS.
Motivation
Supply chain security hardening. Actions pinned to mutable version tags (
@v6,@v4) can be compromised — especially risky on the release workflow which hascontents: writeandid-token: writepermissions.Changes
test.yml,release.yml, andpages.yml(version kept as comment)npm audit fix— 0 vulnerabilities remaining (was 5, including 1 high-severityfast-xml-parser)@magnontaand@cayohollandaas default reviewersType of change
How to test or review
Security and privacy checklist
User impact
None — CI/CD pipeline changes only.
Breaking changes or migration notes
None.