-
Notifications
You must be signed in to change notification settings - Fork 103
add multi2multivec-weaviate vectorizer #1857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Infrastructure as Code | View in Orca | ||
| SAST | View in Orca | ||
| Secrets | View in Orca | ||
| Vulnerabilities | View in Orca |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1857 +/- ##
==========================================
- Coverage 86.80% 86.71% -0.10%
==========================================
Files 273 273
Lines 19059 19695 +636
==========================================
+ Hits 16544 17078 +534
- Misses 2515 2617 +102 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5387c83 to
0ab89a2
Compare
dirkkul
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a test under test/collection/test_config.py?
| @staticmethod | ||
| def multi2vec_weaviate( | ||
| *, | ||
| image_field: str, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @dirkkul wdyt about this vs image_fields: list[str] for this context?
Per @augustas1 we expect only 1 image prop to be vectorized for this use context (image-based document retrieval). But just wanted to check for consistency with other modules & preserving optionality if we add other models.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @dirkkul wdyt about this vs image_fields: list[str] for this context?
fine with me, we can always replace it it Union[str, list[str]] later without breaking anything
Introducing
multi2multivec-weaviatevectorizer.Accepts only 1 image field when configuring vectorizer.
Module PR: weaviate/weaviate#9520