Open
Conversation
metsma
force-pushed
the
icons
branch
2 times, most recently
from
32512d3 to
6b5b80f
Compare
metsma
force-pushed
the
icons
branch
3 times, most recently
from
cd8929b to
fc8ccb3
Compare
WE2-993 Signed-off-by: Raul Metsma <raul@metsma.ee>
mrts
requested changes
Mar 12, 2026
| warnIcon->setVisible(warning.isEmpty() && cardCertPinInfo.pinInfo.pinIsBlocked()); | ||
| warn->setVisible(warning.isEmpty() && cardCertPinInfo.pinInfo.pinIsBlocked()); | ||
| info->parentWidget()->setDisabled(isError); | ||
| warn->setVisible(isError); |
Member
There was a problem hiding this comment.
warn is initialized to "Pin locked" above, so now expired or not-effective certificate will be rendered as disabled and also mislabeled as PIN-locked. This is confusing for the user. Before this commit, the warning label was only shown when the PIN was actually blocked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WE2-993
Signed-off-by: Raul Metsma raul@metsma.ee