Skip to content

fix(cc-components): correct recording state during hold/unhold operations #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bhabalan merged 2 commits into from
May 19, 2026
Merged

fix(cc-components): correct recording state during hold/unhold operations #685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9d2f14
fix(cc-components): correct recording state during hold/unhold operat…
bhabalan May 14, 2026
db2fcaf
Merge branch 'next' into CAI-7859
bhabalan May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/contact-center/cc-components/src/components/task/CallControl/call-control.utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,7 @@ export const updateCallStateFromTask = (

if (callProcessingDetails) {
const {isPaused} = callProcessingDetails;
setIsRecording(!isPaused);
setIsRecording(isPaused !== 'true');
}
} catch (error) {
logger?.error('CC-Widgets: CallControl: Error in updateCallStateFromTask', {
Expand Down
44 changes: 41 additions & 3 deletions ...ges/contact-center/cc-components/tests/components/task/CallControl/call-control.utils.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -722,7 +722,7 @@ describe('CallControl Utils', () => {
it('should update recording state from task data', () => {
updateCallStateFromTask(mockCurrentTask as unknown as ITask, mockSetIsRecording);

expect(mockSetIsRecording).toHaveBeenCalledWith(true); // !isPaused = !false = true
expect(mockSetIsRecording).toHaveBeenCalledWith(true);
});

it('should handle task with recording paused', () => {
Expand All @@ -733,15 +733,53 @@ describe('CallControl Utils', () => {
interaction: {
...mockCurrentTask.data.interaction,
callProcessingDetails: {
isPaused: true,
isPaused: 'true',
},
},
},
};

updateCallStateFromTask(taskWithPausedRecording as unknown as ITask, mockSetIsRecording);

expect(mockSetIsRecording).toHaveBeenCalledWith(false); // !isPaused = !true = false
expect(mockSetIsRecording).toHaveBeenCalledWith(false);
});

it('should handle isPaused as string "true" from backend', () => {
const taskWithStringPaused = {
...mockCurrentTask,
data: {
...mockCurrentTask.data,
interaction: {
...mockCurrentTask.data.interaction,
callProcessingDetails: {
isPaused: 'true',
},
},
},
};

updateCallStateFromTask(taskWithStringPaused as unknown as ITask, mockSetIsRecording);

expect(mockSetIsRecording).toHaveBeenCalledWith(false);
});

it('should handle isPaused as string "false" from backend', () => {
const taskWithStringNotPaused = {
...mockCurrentTask,
data: {
...mockCurrentTask.data,
interaction: {
...mockCurrentTask.data.interaction,
callProcessingDetails: {
isPaused: 'false',
},
},
},
};

updateCallStateFromTask(taskWithStringNotPaused as unknown as ITask, mockSetIsRecording);

expect(mockSetIsRecording).toHaveBeenCalledWith(true);
});

it('should return early when currentTask is null', () => {
Expand Down
Loading